From 56aaa5edd78a719289f2c8413d8a67d27b205150 Mon Sep 17 00:00:00 2001 From: April Sylph <28949509+AprilSylph@users.noreply.github.com> Date: Mon, 28 Feb 2022 14:45:25 +0000 Subject: [PATCH] clean up page state upon form reset ...as opposed to upon form population with no paletteKey. --- src/options/ui.js | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/options/ui.js b/src/options/ui.js index 164ac50..d2db1c9 100644 --- a/src/options/ui.js +++ b/src/options/ui.js @@ -41,10 +41,6 @@ const populateForm = ({ paletteKey, paletteData }) => { paletteForm.dataset.editing = paletteKey; createdTime.textContent = getTimestamp(paletteKey); deleteButton.disabled = false; - } else { - delete paletteForm.dataset.editing; - createdTime.textContent = ''; - deleteButton.disabled = true; } for (const [propertyName, propertyValue] of Object.entries(paletteData)) { @@ -97,6 +93,14 @@ const deleteCurrentPalette = async () => { } }; +const onFormReset = () => { + delete paletteForm.dataset.editing; + createdTime.textContent = ''; + + disableSaveButton(); + deleteButton.disabled = true; +}; + const onFormSubmitted = async event => { event.preventDefault(); @@ -159,7 +163,7 @@ getBuiltInPaletteList.then(builtInPaletteList => { )); }); -paletteForm.addEventListener('reset', disableSaveButton); +paletteForm.addEventListener('reset', onFormReset); paletteForm.addEventListener('submit', onFormSubmitted); paletteForm.addEventListener('input', updatePreview); paletteForm.reset();