Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Add infinite loop detection for badly written custom 404 responses #272

Closed
Zapotek opened this Issue · 1 comment

1 participant

@Zapotek
Owner

The are broken custom 404 responses out there which use relative paths, so if, for example, this URL is requested:

http://stuff.com/non/existent/path/

They include something like:

<a href="sitemap">Sitemap</a>

As part of the standard menu.

However, when converted to absolute, that URL will become http://stuff.com/non/existent/path/sitemap and cause yet another similar 404 response leading to an infinite loop.

The Spider needs to be updated in order to identify custom 404 pages and keep track of their relative links.

(cc @rbgCode)

@Zapotek Zapotek removed this from the v0.5 milestone
@Zapotek
Owner

My idea wouldn't guarantee that the resulting path would be a 404, just that it's likely to.
So, gotta close this, I don't like messing with coverage based on heuristics.

@Zapotek Zapotek closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.