Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent enhancements #1

Merged
merged 12 commits into from Aug 9, 2019

Conversation

@sohkai
Copy link
Collaborator

commented Aug 9, 2019

Mostly small cosmetic improvements and optimizations. Also adds some enhancements to the tests, especially revert strings :).

Easiest to review commit by commit. The important ones that change contract functionality:

  • 1f6c9f9: Makes the forwarding check similar to Voting's, rather than using authP directly. I generally prefer the require(canForward()) mechanism since canForward() is meant to be 1:1 related to whether or not you can forward
  • 14576ae: some small optimizations (returndatasize is very cheap to use directly)
  • 22392f7: Adds the token address to the authP parameters for adding / removing protected tokens
  • aa05a88: Adds a getter for the length of protected tokens; not super useful but we have space in this contract :)

sohkai added some commits Aug 8, 2019

@sohkai sohkai requested a review from osarrouy Aug 9, 2019

@osarrouy

This comment has been minimized.

Copy link

commented on apps/agent/contracts/Agent.sol in 14576ae Aug 9, 2019

Do you also get gas refund that way ?

EDIT. Answered off-github: yes :)

@osarrouy osarrouy merged commit e47298f into master Aug 9, 2019

@sohkai sohkai deleted the agent-changes branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.