Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also test ArvGevSCPSFireTestPacket for auto packet size. #886

Closed
wants to merge 1 commit into from

Conversation

feuerste
Copy link
Contributor

@feuerste feuerste commented Mar 15, 2024

Some cameras, e.g. the Allied Vision Alvium G1, don't have the GevSCPSFireTestPacket feature, but only the ArvGevSCPSFireTestPacket, so we now test both.

Some cameras, e.g. the Allied Vision Alvium G1 doesn't have the
GevSCPSFireTestPacket feature, but only the ArvGevSCPSFireTestPacket.
@feuerste feuerste changed the title Also test ArvGevSCPSFireTestPacket for auto packet size. Also test ArvGevSCPSFireTestPacket for auto packet size. Mar 15, 2024
@feuerste
Copy link
Contributor Author

feuerste commented Mar 16, 2024

@EmmanuelP I just saw a comment in e30bdaf about GevSCPSFireTestPacket. I guess my PR does not make sense, as the Arv prefixed version ArvGevSCPSFireTestPacket is only internal to aravis and always available, right? However, the test_packet_check function also uses the prefixed version. With the changes in this PR (basically resulting in the feature check to be always true) the Allied Vision Alvium G1 is able to do automatic packet size adjustments, without it it isn't.
Would you mind to explain what exactly happens with the prefix? Thanks a lot!

@feuerste
Copy link
Contributor Author

feuerste commented Mar 18, 2024

@EmmanuelP I just saw a comment in e30bdaf about GevSCPSFireTestPacket. I guess my PR does not make sense, as the Arv prefixed version ArvGevSCPSFireTestPacket is only internal to aravis and always available, right? However, the test_packet_check function also uses the prefixed version. With the changes in this PR (basically resulting in the feature check to be always true) the Allied Vision Alvium G1 is able to do automatic packet size adjustments, without it it isn't. Would you mind to explain what exactly happens with the prefix? Thanks a lot!

Thinking more about this, would a viable alternative to checking the availability of GevSCPSFireTestPacket be that we entirely remove the check and add a timeout instead, so the auto_packet_size function is not permitted to take more than a second or couple of seconds? So in case of a DMK 23G618, where one test packet takes 300 ms, we would just time out and return the current packet size...

@feuerste
Copy link
Contributor Author

Closing this in favor of #888.

@feuerste feuerste closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant