Add support to automatic register handler annotated with RegisterActionH... by igieon · Pull Request #292 · ArcBees/GWTP

igieon · 2013-07-17T10:57:43Z

No description provided.

…onHandler

jDramaix · 2013-07-17T11:32:59Z

Not valid license

I meant this it not the license headers used in others files

jDramaix · 2013-07-17T11:44:46Z

Thanks for contributing !

I think we could do the same for the non-spring part of gwt-dispatch ?

igieon · 2013-07-17T11:46:36Z

Need to something to change in my contribution ?
"I think we could do the same for the non-spring part of gwt-dispatch ?" what about this ?

jDramaix · 2013-07-17T12:07:58Z

Need to something to change in my contribution ?

Put the right license header on all files and remove the @author definition in your javadocs. Check also the length of your lines, they should not exceed 120 chars.

"I think we could do the same for the non-spring part of gwt-dispatch ?" what about this ?

It was just a suggestion/ open question. IIRC, when you define a ActionHandler and that you don't use Spring, you have to bind your handler using :

bindHandler( Action.class, Handler.class, Validator.class );

We could maybe implements the same mechanism with guice : simply detect the ActionHandler annotated with RegisterActionHandler and bind them automatically (I guess it should be doable). I just want to offer the same feature whatever your are using spring or not.

igieon · 2013-07-17T12:35:37Z

Ok I modify it and resubmit patch.

igieon · 2013-07-17T12:36:04Z

About guice i need to look into guice more to understand how do it on it.

jDramaix · 2013-07-17T12:52:39Z

Ok I modify it and resubmit patch.

Just commit your changes in your branch and push your branch in the remote repo, that should update this PR

branflake2267 · 2013-07-17T13:38:17Z

Nice job on the source.

Teamcity pull build is complaining a little about checkstyle yet. Might be the first new line after the first class curly.

igieon · 2013-07-17T13:49:16Z

Could you provide update for checkstyle because now maven checkstyle didn't complain about class curly. Or eclipse formater and clean up for you style. Thanks.

branflake2267 · 2013-07-17T14:08:42Z

Here are the rules for the checkstyle, and one of these can be added to the eclipse plugin https://github.com/ArcBees/GWTP/tree/master/gwtp-build-tools/src/main/resources

branflake2267 · 2013-07-17T14:10:10Z

remove new lines after the first class curly. :) This may be one of the checkstyle complaints.

igieon · 2013-07-17T14:19:29Z

I use https://github.com/ArcBees/GWTP/tree/master/gwtp-build-tools/src/main/resources this one but the eclipse nor the maven checkstyle doesn't complain about this lines.

branflake2267 · 2013-07-17T14:29:22Z

Good question, not sure which items its complaining about, I thought maybe that might be it. :) mvn checkstyle:checkstyle might tell a better story.

igieon · 2013-07-17T14:39:13Z

ok here is my command line about checkstyle after remove new lines no checkstyle complain and before alse

C:\Users\davidignjic\Documents\GitHub\GWTP\gwtp-core\gwtp-dispatch-server-spring [master +1 ~1 -0 !]> git log -2
commit 8d7b2456849fa10d84d7e57a90c04902edfbdc49
Author: David Ignjić <ignjic@gmail.com>
Date:   Wed Jul 17 16:32:22 2013 +0200

    Remove empty new lines

commit 6d7f8fe8a961018183ef5dfa5862dc1f8098da89
Author: David Ignjić <ignjic@gmail.com>
Date:   Wed Jul 17 15:05:48 2013 +0200

    Modify source to  comply with checkstyle
C:\Users\davidignjic\Documents\GitHub\GWTP\gwtp-core\gwtp-dispatch-server-spring [master +1 ~1 -0 !]> mvn checkstyle:che
ckstyle
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building GWTP Dispatch Server, Spring implementation 1.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.7:checkstyle (default-cli) @ gwtp-dispatch-server-spring ---
[INFO] Starting audit...
Audit done.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.027s
[INFO] Finished at: Wed Jul 17 16:36:18 CEST 2013
[INFO] Final Memory: 17M/217M
[INFO] ------------------------------------------------------------------------
C:\Users\davidignjic\Documents\GitHub\GWTP\gwtp-core\gwtp-dispatch-server-spring [master +1 ~1 -0 !]> git checkout 6d7f8
fe8a961018183ef5dfa5862dc1f8098da89
M       gwtp-core/gwtp-dispatch-server-guice/src/main/java/com/gwtplatform/dispatch/server/guice/actionhandlervalidator/
LazyActionHandlerValidatorRegistryImpl.java
Note: checking out '6d7f8fe8a961018183ef5dfa5862dc1f8098da89'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 6d7f8fe... Modify source to  comply with checkstyle
C:\Users\davidignjic\Documents\GitHub\GWTP\gwtp-core\gwtp-dispatch-server-spring [(6d7f8fe...) +1 ~1 -0 !]> mvn clean ch
eckstyle:checkstyle
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building GWTP Dispatch Server, Spring implementation 1.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ gwtp-dispatch-server-spring ---
[INFO] Deleting C:\Users\davidignjic\Documents\GitHub\GWTP\gwtp-core\gwtp-dispatch-server-spring\target
[INFO]
[INFO] --- maven-checkstyle-plugin:2.7:checkstyle (default-cli) @ gwtp-dispatch-server-spring ---
[INFO] Starting audit...
Audit done.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.354s
[INFO] Finished at: Wed Jul 17 16:36:50 CEST 2013
[INFO] Final Memory: 18M/217M
[INFO] ------------------------------------------------------------------------
C:\Users\davidignjic\Documents\GitHub\GWTP\gwtp-core\gwtp-dispatch-server-spring [(6d7f8fe...) +1 ~1 -0 !]>

branflake2267 · 2013-07-17T14:43:55Z

Hmm... @meriouma do you know what might be going on with checkstyle?

meriouma · 2013-07-17T16:55:46Z

I'm looking at it

meriouma · 2013-07-17T17:42:58Z

Your ArcBees/GWTP git remote seems out of date (hence the conflict). You need to merge ArcBees/GWTP:master in your igieon/GWTP:master branch

Conflicts: gwtp-core/gwtp-dispatch-server-spring/src/main/java/com/gwtplatform/dispatch/server/spring/actionhandlervalidator/LazyActionHandlerValidatorRegistryImpl.java

igieon · 2013-07-18T07:03:57Z

Merged with master

christiangoudreau · 2013-07-18T14:47:49Z

@imrabti could you do a review?

imrabti · 2013-07-18T17:53:56Z

LGTM,
To use this new annotation, we need to declare AnnotatedActionBeandHandlerRegistrator as a Bean Right ?

igieon · 2013-07-18T18:13:47Z

Yes, as you can see in test.

Add support to automatic register handler annotated with RegisterActionH...

christiangoudreau · 2013-08-13T14:44:22Z

This seems undocumented. @imrabti could you please document this feature in the wiki?

igieon · 2013-08-13T14:54:51Z

Provide some example in wiki or what ?

christiangoudreau · 2013-08-13T16:22:26Z

Exactly

Add support to automatic register handler annotated with RegisterActionH...

Add support to automatic register handler annotated with RegisterActionH... Former-commit-id: fec0ac4

Add support to automatic register handler annotated with RegisterActi…

0322dcf

…onHandler

jDramaix reviewed Jul 17, 2013
View reviewed changes

Modify source to comply with checkstyle

6d7f8fe

branflake2267 reviewed Jul 17, 2013
View reviewed changes

Remove empty new lines

8d7b245

Merge remote-tracking branch 'upstream/master'

c1ef17e

Conflicts: gwtp-core/gwtp-dispatch-server-spring/src/main/java/com/gwtplatform/dispatch/server/spring/actionhandlervalidator/LazyActionHandlerValidatorRegistryImpl.java

christiangoudreau added a commit that referenced this pull request Jul 18, 2013

Merge pull request #292 from igieon/master

f53d899

Add support to automatic register handler annotated with RegisterActionH...

christiangoudreau merged commit f53d899 into ArcBees:master Jul 18, 2013

christiangoudreau added a commit that referenced this pull request Apr 4, 2014

Merge pull request #292 from igieon/master

fec0ac4

Add support to automatic register handler annotated with RegisterActionH...

hpehl pushed a commit to hpehl/GWTP that referenced this pull request Dec 9, 2014

Merge pull request ArcBees#292 from igieon/master

d0fd1b9

Add support to automatic register handler annotated with RegisterActionH... Former-commit-id: fec0ac4

Uh oh!

Conversation

igieon commented Jul 17, 2013

Uh oh!

jDramaix Jul 17, 2013

Choose a reason for hiding this comment

Uh oh!

jDramaix Jul 17, 2013

Choose a reason for hiding this comment

Uh oh!

jDramaix commented Jul 17, 2013

Uh oh!

igieon commented Jul 17, 2013

Uh oh!

jDramaix commented Jul 17, 2013

Uh oh!

igieon commented Jul 17, 2013

Uh oh!

igieon commented Jul 17, 2013

Uh oh!

jDramaix commented Jul 17, 2013

Uh oh!

branflake2267 commented Jul 17, 2013

Uh oh!

igieon commented Jul 17, 2013

Uh oh!

branflake2267 commented Jul 17, 2013

Uh oh!

branflake2267 Jul 17, 2013

Choose a reason for hiding this comment

Uh oh!

igieon commented Jul 17, 2013

Uh oh!

branflake2267 commented Jul 17, 2013

Uh oh!

igieon commented Jul 17, 2013

Uh oh!

branflake2267 commented Jul 17, 2013

Uh oh!

meriouma commented Jul 17, 2013

Uh oh!

meriouma commented Jul 17, 2013

Uh oh!

igieon commented Jul 18, 2013

Uh oh!

christiangoudreau commented Jul 18, 2013

Uh oh!

imrabti commented Jul 18, 2013

Uh oh!

igieon commented Jul 18, 2013

Uh oh!

christiangoudreau commented Aug 13, 2013

Uh oh!

igieon commented Aug 13, 2013

Uh oh!

christiangoudreau commented Aug 13, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants