New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch Projects Update #316

Merged
merged 81 commits into from Dec 2, 2013

Conversation

Projects
None yet
5 participants
@Chris-V
Member

Chris-V commented Aug 21, 2013

_Change Log:_

gwtp-dispatch-rest

  • Replaced Piriti by gwt-jackson
  • Removed missing jax-rs annotation from the compile report
  • Added extension points and interfaces
  • Moved some code from the RestDispatch implementation to RestDispatchCall

gwtp-dispatch-client

  • Renamed artifact to gwtp-dispatch-rpc-client
  • Moved classes to com.gwtplatform.dispatch.rpc.client.*
  • The old classes are still there but are deprecated. If you wish to stay up to date and prevent future migration issues, make sure you use the classes available in com.gwtplatform.dispatch.rpc.client.*
  • Added extension points and interfaces
  • Moved some code from the DispatchAsync implementation to RpcDispatchExecuteCall and RpcDispatchUndoCall. They have the same extensions points DispatchAsync previously had

gwtp-dispatch-server

  • Renamed artifact to gwtp-dispatch-rpc-server
  • Moved classes to com.gwtplatform.dispatch.rpc.server.*
  • The old classes are still there but are deprecated. If you wish to stay up to date and prevent future migration issues, make sure you use the classes available in com.gwtplatform.dispatch.rpc.server.*

gwtp-dispatch-server-guice

  • Renamed artifact to gwtp-dispatch-rpc-server-guice
  • Moved classes to com.gwtplatform.dispatch.rpc.server.guice.*
  • The old classes are still there but are deprecated. If you wish to stay up to date and prevent future migration issues, make sure you use the classes available in com.gwtplatform.dispatch.rpc.server.guice.*

gwtp-dispatch-server-spring

  • Renamed artifact to gwtp-dispatch-rpc-server-spring
  • Moved classes to com.gwtplatform.dispatch.rpc.server.spring.*
  • The old classes are still there but are deprecated. If you wish to stay up to date and prevent future migration issues, make sure you use the classes available in com.gwtplatform.dispatch.rpc.server.spring.*

gwtp-dispatch-shared

  • Renamed artifact to gwtp-dispatch-rpc-shared
  • Moved classes to com.gwtplatform.dispatch.rpc.shared.*
  • The old classes are still there but are deprecated. If you wish to stay up to date and prevent future migration issues, make sure you use the classes available in com.gwtplatform.dispatch.rpc.shared.*

Additions

  • Created 2 new artifacts gwtp-dispatch-common-shared and gwtp-dispatch-common-client. They contain code (ie: DispatchCall abstraction) shared by both the REST and RPC dispatch projects.

Chris-V added some commits Aug 14, 2013

Merge branch 'cv_errai_marshalling' into cv_rest_dispatch_standalone
Conflicts:
	gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/client/gin/RestDispatchAsyncModule.java
	gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/client/rest/RestDispatchAsync.java
Merge pull request #311 from ArcBees/cv_carstore_update
Updated the carstore for the new serializer and rest service syntax
Merge branch 'cv_errai_marshalling' of github.com:ArcBees/GWTP into c…
…v_rest_dispatch_standalone

Conflicts:
	gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/client/rest/ActionMetadataProvider.java
Merge pull request #309 from ArcBees/cv_rest_dispatch_standalone
GJ-4: Remove the need for the Result interface
@jDramaix

This comment has been minimized.

Show comment
Hide comment
@jDramaix

jDramaix Aug 21, 2013

Contributor

very looong PR :)

Two comments :

  • some javadocs on GWTP class should be helpful
  • I don't like that people have to use the errai annotation on their dto. We are now linked to the errai framework. I think that the way we serialize/deserialize object to/from JSOn should be transparent and we should be able in the future to change that without impacting the final developer.
Contributor

jDramaix commented Aug 21, 2013

very looong PR :)

Two comments :

  • some javadocs on GWTP class should be helpful
  • I don't like that people have to use the errai annotation on their dto. We are now linked to the errai framework. I think that the way we serialize/deserialize object to/from JSOn should be transparent and we should be able in the future to change that without impacting the final developer.

Chris-V added some commits Nov 21, 2013

Merge pull request #351 from ArcBees/cv_dispatch_extension_points
Add extension points to the dispatch code
Merge pull request #348 from ArcBees/cv_dispatch_client_common_2
Extracted common code between RPC and REST DispatchAsync
Merge pull request #318 from ArcBees/cv_dispatch_client_common
Extract common code from dispatch projects (part 1)
Merge branch 'master' of github.com:ArcBees/GWTP into cv_rest_dispatc…
…h_update

Conflicts:
	gwtp-build-tools/pom.xml
	gwtp-carstore/pom.xml
	gwtp-carstore/src/main/java/com/gwtplatform/carstore/server/rest/ManufacturerResource.java
	gwtp-core/gwtp-all/pom.xml
	gwtp-core/gwtp-clients-common/pom.xml
	gwtp-core/gwtp-crawler/pom.xml
	gwtp-core/gwtp-dispatch-rest/pom.xml
	gwtp-core/gwtp-dispatch-rpc-client/pom.xml
	gwtp-core/gwtp-dispatch-rpc-server-guice/pom.xml
	gwtp-core/gwtp-dispatch-rpc-server-spring/pom.xml
	gwtp-core/gwtp-dispatch-rpc-server/pom.xml
	gwtp-core/gwtp-dispatch-rpc-shared/pom.xml
	gwtp-core/gwtp-dispatch-rpc-test/pom.xml
	gwtp-core/gwtp-mvp-client/pom.xml
	gwtp-core/gwtp-processors/pom.xml
	gwtp-core/gwtp-tester/pom.xml
	gwtp-core/pom.xml
	gwtp-crawler-service/pom.xml
	pom.xml
@Chris-V

This comment has been minimized.

Show comment
Hide comment
@Chris-V

Chris-V Dec 2, 2013

Member

@christiangoudreau @olafleur @meriouma @olafleur @PhilBeaudoin
I'm merging now, you can still review this branch (12.5k changes...) or go back to the other PRs. I summarized the change log in the description and the doc should be up to date here https://github.com/ArcBees/GWTP/wiki/Rest-Dispatch-1.1.

Member

Chris-V commented Dec 2, 2013

@christiangoudreau @olafleur @meriouma @olafleur @PhilBeaudoin
I'm merging now, you can still review this branch (12.5k changes...) or go back to the other PRs. I summarized the change log in the description and the doc should be up to date here https://github.com/ArcBees/GWTP/wiki/Rest-Dispatch-1.1.

Chris-V added a commit that referenced this pull request Dec 2, 2013

@Chris-V Chris-V merged commit 1f07781 into master Dec 2, 2013

1 check passed

default TeamCity Build GWT-Platform (GWTP) :: Monitor Pulls finished: Tests passed: 90
Details

@Chris-V Chris-V deleted the cv_rest_dispatch_update branch Dec 2, 2013

Chris-V added a commit that referenced this pull request Apr 4, 2014

hpehl pushed a commit to hpehl/GWTP that referenced this pull request Dec 9, 2014

Merge pull request #316 from ArcBees/cv_rest_dispatch_update
Updated Dispatch Projects


Former-commit-id: 9e0d3ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment