New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted common code between RPC and REST DispatchAsync #348

Merged
merged 25 commits into from Nov 23, 2013

Conversation

Projects
None yet
5 participants
@Chris-V
Member

Chris-V commented Nov 20, 2013

Since these two classes share a lot of code but not the same interfaces, I had to introduce the concept of "dispatch calls". I think this is not so bad because it reduces the responsibilities of the DispatchAsync.

My next PR will introduce backward-compatibility changes so that my Dispatch refactors do not break existing code. Classes that have been moved will be @Deprecated.

@christiangoudreau

This comment has been minimized.

Show comment
Hide comment
@christiangoudreau
Member

christiangoudreau commented Nov 21, 2013

LGTM

/**
*/
public abstract class DispatchCall<A extends TypedAction<R>, R> {

This comment has been minimized.

@branflake2267

branflake2267 Nov 21, 2013

Contributor

Does this have a unit test?

@branflake2267

branflake2267 Nov 21, 2013

Contributor

Does this have a unit test?

This comment has been minimized.

@Chris-V

Chris-V Nov 21, 2013

Member

I can see at least two test cases here. I will try to see how easy they are to write.

@Chris-V

Chris-V Nov 21, 2013

Member

I can see at least two test cases here. I will try to see how easy they are to write.

@branflake2267

This comment has been minimized.

Show comment
Hide comment
@branflake2267

branflake2267 Nov 21, 2013

Contributor

Nice job

Contributor

branflake2267 commented Nov 21, 2013

Nice job

import com.gwtplatform.dispatch.shared.SecurityCookieAccessor;
import com.gwtplatform.dispatch.shared.TypedAction;
/**

This comment has been minimized.

@branflake2267

branflake2267 Nov 21, 2013

Contributor

missing javadoc?

@branflake2267

branflake2267 Nov 21, 2013

Contributor

missing javadoc?

This comment has been minimized.

@Chris-V

Chris-V Nov 21, 2013

Member

I have a task to update all javadoc before everything is pushed in master. It will be easier to review in a separate PR

@Chris-V

Chris-V Nov 21, 2013

Member

I have a task to update all javadoc before everything is pushed in master. It will be easier to review in a separate PR

This comment has been minimized.

@branflake2267

branflake2267 Nov 21, 2013

Contributor

cool!

@branflake2267

branflake2267 Nov 21, 2013

Contributor

cool!

@meriouma

This comment has been minimized.

Show comment
Hide comment
@meriouma

meriouma Nov 21, 2013

Member

LGTM

Member

meriouma commented Nov 21, 2013

LGTM

@jDramaix

This comment has been minimized.

Show comment
Hide comment
@jDramaix

jDramaix Nov 22, 2013

Contributor

LGTM

Contributor

jDramaix commented Nov 22, 2013

LGTM

Chris-V added a commit that referenced this pull request Nov 23, 2013

Merge pull request #348 from ArcBees/cv_dispatch_client_common_2
Extracted common code between RPC and REST DispatchAsync

@Chris-V Chris-V merged commit 5a8258c into cv_dispatch_client_common Nov 23, 2013

@Chris-V Chris-V deleted the cv_dispatch_client_common_2 branch Nov 23, 2013

Chris-V added a commit that referenced this pull request Apr 4, 2014

Merge pull request #348 from ArcBees/cv_dispatch_client_common_2
Extracted common code between RPC and REST DispatchAsync

hpehl pushed a commit to hpehl/GWTP that referenced this pull request Dec 9, 2014

Merge pull request #348 from ArcBees/cv_dispatch_client_common_2
Extracted common code between RPC and REST DispatchAsync


Former-commit-id: ce7e288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment