New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest/Rpc dispatch interoperability #467

Merged
merged 23 commits into from Jul 30, 2014

Conversation

Projects
None yet
3 participants
@Chris-V
Member

Chris-V commented Apr 7, 2014

This changes makes it possible to use both dispatchers together by binding common interfaces to an annotation (@RpcBinding and @RestBinding).

The auto-format went a bit crazy, but the format is fine so I send it as well.

@christiangoudreau

This comment has been minimized.

Show comment
Hide comment
@christiangoudreau

christiangoudreau Apr 8, 2014

Member

Example? LGTM

Member

christiangoudreau commented Apr 8, 2014

Example? LGTM

@Chris-V

This comment has been minimized.

Show comment
Hide comment
@Chris-V

Chris-V Apr 8, 2014

Member

There's no example. You just use both dispatchers as you would use them, except that they won't clash together.

Member

Chris-V commented Apr 8, 2014

There's no example. You just use both dispatchers as you would use them, except that they won't clash together.

@meriouma

This comment has been minimized.

Show comment
Hide comment
@meriouma

meriouma Apr 8, 2014

Member

LGTM

Member

meriouma commented Apr 8, 2014

LGTM

@meriouma

This comment has been minimized.

Show comment
Hide comment
@meriouma

meriouma Apr 8, 2014

Member

But we could setup both dispatchers in the CarStore to ensure it keeps working?

Member

meriouma commented Apr 8, 2014

But we could setup both dispatchers in the CarStore to ensure it keeps working?

@Chris-V

This comment has been minimized.

Show comment
Hide comment
@Chris-V

Chris-V Apr 8, 2014

Member

Sure

Member

Chris-V commented Apr 8, 2014

Sure

@Chris-V Chris-V self-assigned this Apr 28, 2014

meriouma added some commits May 26, 2014

Merge remote-tracking branch 'origin/master' into cv_dispatch_interop…
…erability

Conflicts:
	gwtp-core/gwtp-tester/src/main/java/com/gwtplatform/tester/TestDispatchModule.java
Merge remote-tracking branch 'origin/master' into cv_dispatch_interop…
…erability

Conflicts:
	gwtp-core/gwtp-dispatch-common-client/src/main/java/com/gwtplatform/dispatch/client/gin/AbstractDispatchAsyncModule.java
	gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/rest/client/DefaultRestDispatchCallFactory.java
	gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/rest/client/RestDispatchCall.java
	gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/rest/client/gin/RestDispatchAsyncModule.java
	gwtp-core/gwtp-dispatch-rpc-client/src/main/java/com/gwtplatform/dispatch/rpc/client/DefaultRpcDispatchCallFactory.java
	gwtp-core/gwtp-dispatch-rpc-client/src/main/java/com/gwtplatform/dispatch/rpc/client/RpcDispatchExecuteCall.java
	gwtp-core/gwtp-dispatch-rpc-client/src/main/java/com/gwtplatform/dispatch/rpc/client/RpcDispatchUndoCall.java
Merge branch 'cv_dispatch_interoperability' into mmc_dispatch_interop
Conflicts:
	gwtp-carstore/pom.xml
	gwtp-carstore/src/main/resources/com/gwtplatform/carstore/SuperDevMode.gwt.xml
	pom.xml
Merge pull request #532 from ArcBees/mmc_multiple_hooks
Allow different DispatchHooks for REST and RPC dispatchers
Merge pull request #534 from ArcBees/mmc_dispatch_builder
Changed return type of Builder to return correct type
Merge pull request #531 from ArcBees/mmc_interop_hooks
Fixed DispatchHooks binding when using both dispatchers
Merge pull request #528 from ArcBees/mmc_dispatch_interop
Added RPC dispatch in CarStore to showcase dispatcher coexistence

meriouma added a commit that referenced this pull request Jul 30, 2014

@meriouma meriouma merged commit 6e33a2f into master Jul 30, 2014

1 check passed

default TeamCity Build GWT-Platform (GWTP) :: Monitor Pulls finished: Tests passed: 110
Details

@meriouma meriouma deleted the cv_dispatch_interoperability branch Jul 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment