New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull-request-id as customized build parameter #65

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
2 participants
@O5ten
Contributor

O5ten commented Apr 4, 2018

To be provided from trigger to the rest of the build so it can be provided to other integrations such as
sonar that requires the pull-request id to delegate sonar comments to sonar plugins

trigger.pullRequestId can now be used in throughout the build-steps.

Example-integration that i need it for.
https://github.com/mibexsoftware/sonar-bitbucket-plugin

mvn clean verify sonar:sonar -Dsonar.bitbucket.pullRequestId=%trigger.pullRequestId%

Seeing as that this repo hasn't moved an inch in a year of two i don't expect it to be merged soon, but my fork is available for anyone who might stumble on the same use-case as me.

mo916607 mo916607
Add pull-request-id as customized build parameter
To be provided from trigger to the rest of the build
so it can be provided to other integrations such as
sonar that requires the pull-request id to delegate
sonar comments to sonar plugins
@O5ten

This comment has been minimized.

Contributor

O5ten commented Apr 4, 2018

Regression tested on my own fork with my own TC instance.
BuildId is printed using echo in a build-step after maven.
O5ten#1

@meriouma meriouma merged commit c8e150c into ArcBees:master Apr 11, 2018

@O5ten O5ten deleted the O5ten:add-pull-request-id-as-provided-build-parameter branch Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment