Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Angel's Refining crashes due to not removing Yuoki ores from map gen presets #373

Closed
randomflyingtaco opened this issue Aug 28, 2020 · 4 comments
Labels
Angels Refining refining related Impact: Mod compatibility Mainly involves 3rd party mods

Comments

@randomflyingtaco
Copy link

Angel's Refining crashes due to not removing Yuoki ores from map gen presets.
For some reason the Yuoki and Uranium Power compatibility blocks here just set the resource and autoplace to nil instead of using remove_resource which also removes removes the resource from map gen presets. I don't know if the solution is as simple as updating the Yuoki and Uranium Power sections to use remove_resource, but I do know that it is causing crashes currently.

image

@randomflyingtaco randomflyingtaco changed the title Angel's Refining crashes due to not removing Yuoki ores from map gen presets [BUG] Angel's Refining crashes due to not removing Yuoki ores from map gen presets Aug 28, 2020
@LovelySanta LovelySanta added Angels Refining refining related Impact: Mod compatibility Mainly involves 3rd party mods labels Aug 30, 2020
@Pezzawinkle
Copy link
Collaborator

Please report this to the Tiberium mod owner (https://github.com/James-Fire/Factorio-Tiberium), this is not specifically an angels issue.
Any mention of Tib-only refers to that mod's generation tweaks, I have had this same error reported on the omnimatter discord over a month ago.

@Pezzawinkle Pezzawinkle added Status: Wont Fix Works as intended and removed Angels Refining refining related Impact: Mod compatibility Mainly involves 3rd party mods labels Sep 16, 2020
@randomflyingtaco
Copy link
Author

I am the Tiberium mod co-owner and am reporting it here because Angel's Refining is coming in after us and deleting the resource after we add it to our preset. You literally have a "remove_resource" function that does the correct thing and it appears in the same file, but aren't using it for Yuoki/Uranium Power.

@LovelySanta LovelySanta reopened this Sep 17, 2020
@LovelySanta LovelySanta added Angels Refining refining related Impact: Mod compatibility Mainly involves 3rd party mods and removed Status: Wont Fix Works as intended labels Sep 17, 2020
@Pezzawinkle
Copy link
Collaborator

Sorry it took soo long to get to this. The patch for this will be live in the next update. I would like to point out that during testing, line 275 of data-updates.lua:
data.raw.resource["uranium-ore"]["map_color"] = {0.0, 0.5, 0.0} -- Desaturate uranium map color to make it not look like Tiberium
Causes a start-up crash, since you are not checking for the existence of uranium before calling that desaturation...

@randomflyingtaco
Copy link
Author

Thanks for coming back to this one. The uranium oversight is already fixed for the next version, but thank you for putting in the time to provide a detailed diagnosis and solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angels Refining refining related Impact: Mod compatibility Mainly involves 3rd party mods
Projects
None yet
Development

No branches or pull requests

3 participants