Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smelting locomotive tender does not accept fuel from AAI nor K2 #520

Closed
adoa opened this issue Jan 12, 2021 · 3 comments
Closed

Smelting locomotive tender does not accept fuel from AAI nor K2 #520

adoa opened this issue Jan 12, 2021 · 3 comments
Assignees
Labels
Angels Addon addon related Impact: Mod compatibility Mainly involves 3rd party mods Status: On hold Awaiting 3rd party input

Comments

@adoa
Copy link
Contributor

adoa commented Jan 12, 2021

AAI Industries and Krastorio 2 add new fuel types.
AAI:

  • processed-fuel

K2:

  • fuel
  • bio-fuel
  • advanced-fuel

The Smelting locomotive tender does not accept these fuel types.
However, the Crawler locomotive tender does accept these fuel types.

This is an inconsistency that might be on our side.

Additional Information
First reported on the forums
https://forums.factorio.com/viewtopic.php?p=531635#p531635

@adoa adoa mentioned this issue Jan 12, 2021
@Pezzawinkle
Copy link
Collaborator

Pezzawinkle commented Jan 13, 2021

Tested with just AAII and AAII+Krastorio2... i can safely confirm that... Krastorio is on the naughty list here...
It changes the AAII processed fuel item from processed-chemical to vehicle-fuel and does not dynamically change the fuel categories of locomotives to match...

Having a dig through the mod, the compatibility-scripts/data-updates/angelsaddons-###.lua file is incorrect and needs updating to the new mod design, as it is, it fails to fire entirely, on that point, same with the compatibility-scripts/data-final-fixes/angelsaddons-###.lua files.

I will try to duplicate this in the Krastorio feedback system.
https://mods.factorio.com/mod/Krastorio2/discussion/5ffebb986e512be65cf94a9c
Linver seems to be pretty quick to fix most of the issues posted.

@Pezzawinkle Pezzawinkle added Angels Addon addon related Impact: Mod compatibility Mainly involves 3rd party mods Status: On hold Awaiting 3rd party input labels Jan 13, 2021
@Pezzawinkle Pezzawinkle self-assigned this Jan 13, 2021
@Pezzawinkle
Copy link
Collaborator

from a quick chat on their discord, it seems they have quite a big backlog, if it is urgent, it may be faster to customise K2's mod files, or create a new patch mod in the interim. But i have been assured it will be patched at some stage.

@Pezzawinkle Pezzawinkle added this to To do in AngelsTrains Mar 9, 2021
@LovelySanta LovelySanta changed the title [Mod Compatibility] [Mass Transit] Smelting locomotive tender does not accept fuel from AAI nor K2 Smelting locomotive tender does not accept fuel from AAI nor K2 Mar 28, 2021
@Pezzawinkle
Copy link
Collaborator

This appears to be very much fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angels Addon addon related Impact: Mod compatibility Mainly involves 3rd party mods Status: On hold Awaiting 3rd party input
Projects
AngelsTrains
  
To do
Development

No branches or pull requests

2 participants