Permalink
Browse files

disable auto validation on toolbar items. fix #602

when auto validate is enabled and user clicks somewhere that doesn't
capture click event, the CPWindowDidChangeFirstResponderNotification
causes toolbars to be revalidated and enabled again, which is not what
we want.
  • Loading branch information...
1 parent 7a63240 commit 5569f1d790999f79b3c357a36a3ce62560f0d3c8 @everplays everplays committed Dec 8, 2012
Showing with 6 additions and 0 deletions.
  1. +6 −0 ArchipelClient/Controllers/TNModuleController.j
@@ -487,6 +487,12 @@ TNArchipelModulesVisibilityRequestNotification = @"TNArchipelModulesVisibilityR
frame = [_mainModuleView bounds],
moduleToolbarItem = [[CPToolbarItem alloc] initWithItemIdentifier:moduleIdentifier];
+ // auto validating of toolbar item should be disabled so
+ // they won't get enabled by theirselves when user clicks
+ // somewhere. for more info take a look at:
+ // https://github.com/ArchipelProject/Archipel/issues/602
+ [moduleToolbarItem setAutovalidates:NO];
+
if ([moduleLabel isKindOfClass:CPDictionary] && bundleLocale)
moduleLabel = [moduleLabel objectForKey:[defaults objectForKey:@"CPBundleLocale"]] || [moduleLabel objectForKey:@"en"];

0 comments on commit 5569f1d

Please sign in to comment.