Skip to content

Enable SingleFile deferred image loading by default#27

Open
dicnunz wants to merge 1 commit into
ArchiveBox:mainfrom
dicnunz:nic/singlefile-deferred-images-default
Open

Enable SingleFile deferred image loading by default#27
dicnunz wants to merge 1 commit into
ArchiveBox:mainfrom
dicnunz:nic/singlefile-deferred-images-default

Conversation

@dicnunz
Copy link
Copy Markdown

@dicnunz dicnunz commented May 20, 2026

Summary

  • add --load-deferred-images-dispatch-scroll-event to the default SingleFile CLI args
  • cover the default with a small config regression test

Fixes ArchiveBox/ArchiveBox#318.

Context

The issue was opened in ArchiveBox/ArchiveBox, but the current SingleFile plugin config lives in this repo. The existing SINGLEFILE_ARGS setting still lets users override the defaults if scroll events cause page-specific side effects.

Verification

  • python3 -m json.tool abx_plugins/plugins/singlefile/config.json >/dev/null
  • uv run pytest abx_plugins/plugins/singlefile/tests/test_singlefile_config.py -q
  • git diff --check

Paid-fix note

If this closes the deferred-image loading gap and saves maintainer time, I am asking $10 here: https://nicdunz.gumroad.com/l/tiny-codex-teardown-direct?wanted=true

No issue if this project only handles volunteer contributions; the patch stands either way.


Summary by cubic

Enable deferred image loading in SingleFile by default to capture lazy-loaded images reliably. Adds the scroll-dispatch flag to the default args and a regression test to prevent regressions.

  • Bug Fixes
    • Add --load-deferred-images-dispatch-scroll-event to default SINGLEFILE_ARGS.
    • Add test to assert the flag is present in the plugin config.

Written for commit 4d315e0. Summary will update on new commits. Review in cubic

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add SingleFile CLI option to fire scroll event and load deferred images to better support WeChat archiving

1 participant