Enable SingleFile deferred image loading by default#27
Open
dicnunz wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--load-deferred-images-dispatch-scroll-eventto the default SingleFile CLI argsFixes ArchiveBox/ArchiveBox#318.
Context
The issue was opened in ArchiveBox/ArchiveBox, but the current SingleFile plugin config lives in this repo. The existing
SINGLEFILE_ARGSsetting still lets users override the defaults if scroll events cause page-specific side effects.Verification
python3 -m json.tool abx_plugins/plugins/singlefile/config.json >/dev/nulluv run pytest abx_plugins/plugins/singlefile/tests/test_singlefile_config.py -qgit diff --checkPaid-fix note
If this closes the deferred-image loading gap and saves maintainer time, I am asking $10 here: https://nicdunz.gumroad.com/l/tiny-codex-teardown-direct?wanted=true
No issue if this project only handles volunteer contributions; the patch stands either way.
Summary by cubic
Enable deferred image loading in SingleFile by default to capture lazy-loaded images reliably. Adds the scroll-dispatch flag to the default args and a regression test to prevent regressions.
--load-deferred-images-dispatch-scroll-eventto defaultSINGLEFILE_ARGS.Written for commit 4d315e0. Summary will update on new commits. Review in cubic