New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make job status less chatty #326

Merged
merged 3 commits into from Sep 22, 2018

Conversation

Projects
None yet
4 participants
@anarcat
Contributor

anarcat commented Sep 22, 2018

The job status is currently two verbose and spams the channel with four lines of log.

So instead of:

09:45:53 <+anarcat> !status 1wm191rekoxp02guomaxcwrpz
09:45:53 <Major> anarcat: Job 1wm191rekoxp02guomaxcwrpz <http://www.threehundredeight.com/>:
09:45:53 <Major> anarcat: Started by anarcat.
09:45:53 <Major> anarcat: In progress.  Downloaded 10915.47 MB, 1187 errors encountered, 0 items queued.
09:45:53 <Major> anarcat: 4 workers, delay: [0.0, 0.0] ms.
09:45:53 <Major> anarcat: See the ArchiveBot dashboard for more information.

We should be seeing something like:

09:45:53 <+anarcat> !status 1wm191rekoxp02guomaxcwrpz
09:45:53 <Major> anarcat: Job 1wm191rekoxp02guomaxcwrpz <http://www.threehundredeight.com/>. Started by anarcat. In progress. Downloaded 10915.47 MB, 1187 errors encountered, 0 items queued. 4 workers, delay: [0.0, 0.0] ms.

Untested: ideally, we'd just return a string instead of an array here, but I'm trying to respect the existing API to avoid breaking too much stuff. But I did test that the bot framework correctly splits long lines: cinch handles that fine.

We also remove the dashboard reference because it is noisy for nothing - it's already in the channel topic and it's not used in other commands which might also need it (e.g. plain !status).

While we here, switch to using MiB to be consistent with dashboard and the rest of the universe.

anarcat added some commits Sep 22, 2018

remove dashboard reference in job status
The reference is noisy for nothing - it's already in the channel topic
and it's not used in other commands which might also need
it (e.g. plain `!status`).
make job status less chatty
The job status is currently two verbose and spams the channel with
four lines of log.

So instead of:

```
09:45:53 <+anarcat> !status 1wm191rekoxp02guomaxcwrpz
09:45:53 <Major> anarcat: Job 1wm191rekoxp02guomaxcwrpz <http://www.threehundredeight.com/>:
09:45:53 <Major> anarcat: Started by anarcat.
09:45:53 <Major> anarcat: In progress.  Downloaded 10915.47 MB, 1187 errors encountered, 0 items queued.
09:45:53 <Major> anarcat: 4 workers, delay: [0.0, 0.0] ms.
09:45:53 <Major> anarcat: See the ArchiveBot dashboard for more information.
```

We should be seeing something like:

```
09:45:53 <+anarcat> !status 1wm191rekoxp02guomaxcwrpz
09:45:53 <Major> anarcat: Job 1wm191rekoxp02guomaxcwrpz <http://www.threehundredeight.com/>. Started by anarcat. In progress. Downloaded 10915.47 MB, 1187 errors encountered, 0 items queued. anarcat: 4 workers, delay: [0.0, 0.0] ms.
```

Untested: ideally, we'd just return a string instead of an array here,
but I'm trying to respect the existing API to avoid breaking too much
stuff.
use MiB to be consistent with dashboard...
... and the rest of the universe
@kiska3

kiska3 approved these changes Sep 22, 2018

@yipdw yipdw merged commit 90bf00b into ArchiveTeam:master Sep 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@anarcat anarcat deleted the anarcat:terse branch Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment