Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Show pending items in queue counter on dashboard #96
This looks okay to me.
I'd like to hold off merging it until the hooks make it into a new wpull release. That way, we can change requirements.txt accordingly, and the usual
One thing: for pipelines that don't have this code, we'll see zero for queued and downloaded items. I don't think this is a big problem: it will eventually be solved as all pipelines are updated, and we can adapt our brains in the meantime.
I don't understand why you think they are always being reset to 0. They are reset to 0 after their value has been added to the global counter in redis.
I created those internal counters just like
I guess the idea is to retry adding the value in case something goes wrong during the redis operation.
Yeah, the idea behind
I'm not sure it's necessary, though -- losing a record here or there might not be worth the odd code flow. It may not actually fulfill its intended purpose: part of
Sep 10, 2014
1 check passed
added a commit
this pull request
Sep 10, 2014
This seems to work pretty well; however, I've noticed that
For the sort of coarse-grained "are we there yet" information we're looking for, this isn't a problem; however, from an accounting perspective, it'd be nice for all quantities to match up