Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Mumble Link identity JSON parsing #39

Closed
Archomeda opened this issue Mar 16, 2020 · 0 comments
Closed

Optimize Mumble Link identity JSON parsing #39

Archomeda opened this issue Mar 16, 2020 · 0 comments
Labels
Area: Mumble Link Related to the Mumble Link API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed

Comments

@Archomeda
Copy link
Owner

The identity is currently cached, but further improvements can be done:

  • Only a maximum of one check per tick has to be done to see if the identity was updated compared to the previous update; currently it compares the identity strings every time, regardless of it has been done already in the same tick
  • The .ToString() call of the race allocates a new string every time, even if it's the same. A static lookup dictionary can be a solution
@Archomeda Archomeda added Priority: Medium Medium priority Duration: Short Less than 2 hours of estimated work Area: Mumble Link Related to the Mumble Link API labels Mar 16, 2020
@Archomeda Archomeda added the Status: Waiting for release Work has finished and is waiting to be released label Mar 16, 2020
@Archomeda Archomeda added Resolution: Fixed The issue has been fixed and removed Status: Waiting for release Work has finished and is waiting to be released labels Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Mumble Link Related to the Mumble Link API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed
Projects
None yet
Development

No branches or pull requests

1 participant