Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into removing the generic type in ILocalizedClient #57

Closed
Archomeda opened this issue Apr 15, 2020 · 0 comments · Fixed by #61
Closed

Look into removing the generic type in ILocalizedClient #57

Archomeda opened this issue Apr 15, 2020 · 0 comments · Fixed by #61
Labels
Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Low Low priority Resolution: Fixed The issue has been fixed Type: Refactor An improvement to the project that doesn't necessarily add a new features

Comments

@Archomeda
Copy link
Owner

As far as I'm aware, requiring a generic type for the payload object isn't necessary since it isn't used in this interface. The same thing was done some time ago with IAuthenticatedClient as well. So it can probably be removed here too.
@Archomeda Archomeda added Priority: Low Low priority Duration: Short Less than 2 hours of estimated work Area: Web API v2 Related to the v2 web API Type: Refactor An improvement to the project that doesn't necessarily add a new features labels Apr 15, 2020
Archomeda added a commit that referenced this issue May 23, 2020
@Archomeda
Remove generic type requirement for ILocalizedClient
a81e5b8 
Resolves #57
@Archomeda Archomeda mentioned this issue May 23, 2020
Merged
@Archomeda Archomeda added the Status: Waiting for release Work has finished and is waiting to be released label May 23, 2020
@Archomeda Archomeda added Resolution: Fixed The issue has been fixed and removed Status: Waiting for release Work has finished and is waiting to be released labels May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Low Low priority Resolution: Fixed The issue has been fixed Type: Refactor An improvement to the project that doesn't necessarily add a new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor clients Archomeda/Gw2Sharp
1 participant
@Archomeda