Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add render API #6

Merged
merged 33 commits into from
Jul 26, 2019
Merged

Add render API #6

merged 33 commits into from
Jul 26, 2019

Conversation

Archomeda
Copy link
Owner

  • Adds the render API, along with /v2/outfits and /v2/pets.
  • Fixes .NET Core 3.0 Preview 7 builds in relation to NullableContextOptions
  • Consolidates a bunch of methods that accepted a CancellationToken as overload into an optional parameter
  • Adds a new root client (Gw2Client) in favor of the old one (Gw2WebApiClient)
  • Removes public constructors of all clients
  • Changes all URL properties into a special class that allows access to the download immediately
  • The BaseEndpointClient no longer contains the endpoint implementation methods on its own; it's been moved into another class and is being used as composition instead
  • And has a bunch more refactoring probably

@Archomeda Archomeda added Type: Feature An addition to the project Area: Render Related to the web render API labels Jul 26, 2019
@Archomeda Archomeda merged commit 783556b into master Jul 26, 2019
@Archomeda Archomeda deleted the add-render branch July 26, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Render Related to the web render API Type: Feature An addition to the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant