Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autograb (without inputlock, for now) #494

Closed

Conversation

@sunweaver
Copy link
Member

commented Jul 24, 2017

@uli42: I took your pr/autograb branch and stripped out the autograb feature only for this PR for now.

The autograb feature is an interesting feature for our current sponsor, so we should have that in nxagent ASAP.

I will add some code, that triggers an NX dialog call when the autograb mode gets enabled. Once that commit is there, I'd love to have you review this subset of commits derived from your pr/autograb branch.

@sunweaver sunweaver requested a review from uli42 Jul 24, 2017

@sunweaver sunweaver self-assigned this Jul 24, 2017

@sunweaver sunweaver added this to the 3.6.0.0 milestone Jul 24, 2017

@uli42

This comment has been minimized.

Copy link
Member

commented Jul 24, 2017

@sunweaver sunweaver force-pushed the sunweaver:pr/autograb-without-inputlock branch from 9bfcc39 to 1382ddc Jul 24, 2017

@sunweaver

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2017

@uli42

This comment has been minimized.

Copy link
Member

commented Jul 24, 2017

@sunweaver

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2017

@uli42

This comment has been minimized.

Copy link
Member

commented Jul 24, 2017

@sunweaver

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2017

@uli42

This comment has been minimized.

Copy link
Member

commented Jul 24, 2017

Ok, more details:

  1. use kwin or openbox on Ubuntu 16.04 lTS. Run nxagent :66. Activate autograb, it is working fine.
    2a. press fullscreen keystroke -> does not work for, makes window disappear. Press fullscreen keystroke again -> window is back
    2b. press allscreens keystroke -> works. Press allscreens keystroke again -> windowed mode is back again. But the window is not active anymore, autograb is not working. You have to activate the window (again) to make autograb work

If you add the patch from #458 2a) works better. However,while in fullscreen you can still press alt-tab to change windows and afterwards the fullscreen keystroke is not working anymore. You have to use alt-tab to (somehow) activate the shell you started nxagent from and then (invisibly, because the fullscreen nxagent is on top and you see only a black screen) press ctrl-c.

So please try to test this with kwin. I think you will agree that we cannot ship it like that...

@sunweaver sunweaver force-pushed the sunweaver:pr/autograb-without-inputlock branch from 1382ddc to 8d57841 Aug 8, 2017

@sunweaver

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2017

I can reproduce the issue with openbox runing on the hosting (local) X.org. Will investigate further, later.

#define DIALOG_ENABLE_AUTOGRAB_MODE_MESSAGE \
\
"\
Keyboard auto-grabbing mode is now enabled. You can press\n\

This comment has been minimized.

Copy link
@uli42

uli42 Aug 8, 2017

Member

I don't like that hardcoded keystroke here. Maybe change the text to "press the same keystroke again to..."

@sunweaver sunweaver force-pushed the sunweaver:pr/autograb-without-inputlock branch from 8d57841 to 93c8be7 Jun 27, 2019

@sunweaver

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

@uli42: I have rebased the autograb-without-inputlock branch, can you give this another try? I can't remember the smoke test to get nxagent burnt (some switching between ctrl-F, ctrl-shift-F and windowed mode. Do you remember? (And with KWin running?)

@uli42

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

It is described within this very issue

(fun fact: I have rebased my autograb branch just today, too)

@sunweaver

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

@uli42

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

I am not sure about my weekend schedules right now. Will decide tomorrow.

However, just tested:

  1. run NX_CLIENT=<path_to_nxdialog> nxagent :55
  2. xterm -display :55
  3. in xterm: startlxde
  4. activate autograb -> works
  5. ctrl-alt-f -> fullscreen
  6. press alt-tab -> fullscreen will vanish while the alt-tab-switcher of your local X gets activated
Make AutoGrab work in more situations
Especially switchin to/from fullscreen with active AutoGrab was
problematic. Works much smoother now.
@uli42

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

https://gist.github.com/uli42/e246c4bfefeb62bccb961f768c4809d4 makes it almost work. When leavin fullscreen mode the window sometimes iconifies.

@sunweaver

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

@uli42 uli42 force-pushed the sunweaver:pr/autograb-without-inputlock branch from 93c8be7 to 96672d7 Jun 28, 2019

@sunweaver

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Superceded by #835.

@sunweaver sunweaver closed this Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.