Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/various2 #827

Merged
merged 70 commits into from Sep 29, 2019

Conversation

@uli42
Copy link
Member

commented Jul 23, 2019

No description provided.

@uli42 uli42 requested a review from sunweaver Jul 23, 2019
@uli42 uli42 force-pushed the uli42:pr/various2 branch from 86a3c1c to 29ee491 Jul 23, 2019
@uli42 uli42 force-pushed the uli42:pr/various2 branch 10 times, most recently from 8112e13 to 431ad1c Jul 31, 2019
@uli42 uli42 force-pushed the uli42:pr/various2 branch 4 times, most recently from e9879d6 to afa8b0a Aug 11, 2019
@sunweaver

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@uli42: please rebase this PR branch and let me know when it is ready to be reviewed.

@uli42

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

@sunweaver

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@uli42 uli42 force-pushed the uli42:pr/various2 branch from afa8b0a to 1aceda0 Sep 1, 2019
@uli42

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2019

rebased

@uli42 uli42 force-pushed the uli42:pr/various2 branch 3 times, most recently from 01ff502 to 4fa377b Sep 6, 2019
uli42 added 26 commits Sep 1, 2019
This way we can remove lots of #ifdef DEBUGs
nxagentTriangles
nxagentTriFan
nxagentTriStrip
It is not dependent on any root window and needs only be called once on
startup.
by reformatting comments and removing blank lines.
One cannot simply pass down a va_list to another function that expects
variable arguments ("..."). The prototype of the called functions must
expect a va_list argument instead.

This fixes segfaults that happen e.g. after compiling X11.cpp with
TEST and effectively reverts 59e829f.
@sunweaver sunweaver force-pushed the uli42:pr/various2 branch from 4bbdd6e to 085f8a4 Sep 29, 2019
Copy link
Member

left a comment

Nice work!!! About to merge this.

sunweaver added a commit that referenced this pull request Sep 29, 2019
Attributes GH PR #827: #827
@sunweaver sunweaver merged commit 085f8a4 into ArcticaProject:3.6.x Sep 29, 2019
3 checks passed
3 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.