Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nxagent: drop nxagentRenderTrap #842

Merged
merged 1 commit into from Sep 29, 2019

Conversation

@uli42
Copy link
Member

commented Sep 1, 2019

This flag is set when internal pixmap creation returns a pixmap with
depth 0. Following that the RENDER extension is effectively
disabled. However: there's no code that could create a pixmap with
depth 0, so let's simplify our code by removing nxagentRenderTrap
altogether.

@uli42 uli42 force-pushed the uli42:pr/drop_faulty_render_check branch from 6c7cd64 to 728580f Sep 1, 2019
@uli42 uli42 requested review from sunweaver and Ionic Sep 1, 2019
@uli42 uli42 force-pushed the uli42:pr/drop_faulty_render_check branch 2 times, most recently from bfcc726 to f8a90ea Sep 1, 2019
@uli42 uli42 force-pushed the uli42:pr/drop_faulty_render_check branch from f8a90ea to a682875 Sep 28, 2019
Copy link
Member

left a comment

Ok.

nxagentRenderTrap is rather old. This flag is set when internal pixmap
creation returns a pixmap with depth 0. Following that the RENDER
extension is effectively disabled. However: there's no code that could
create a pixmap with depth 0, so let's simplify our code by removing
nxagentRenderTrap altogether.

Fixes #841
@sunweaver sunweaver force-pushed the uli42:pr/drop_faulty_render_check branch from a682875 to 5aee32e Sep 29, 2019
sunweaver added a commit that referenced this pull request Sep 29, 2019
Attributes GH PR #842: #842
@sunweaver sunweaver merged commit 5aee32e into ArcticaProject:3.6.x Sep 29, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.