Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/clipboard overhaul #846

Merged
merged 36 commits into from Sep 29, 2019

Conversation

@uli42
Copy link
Member

commented Sep 28, 2019

refactor clipboard code + at least three fixes

@uli42 uli42 requested a review from sunweaver Sep 28, 2019
@sunweaver sunweaver force-pushed the uli42:pr/clipboard_overhaul branch from 15e0432 to 61e7cec Sep 29, 2019
uli42 added 28 commits Aug 3, 2019
There was only one place where this was checked but we check it always.
fixup! Clipboard.c: introduce XSendNotificationEventHelper
Just as everyone else does. ICCCM is not really clear about this.
At some places we were using NumCurrentSelections. We replace that by
nxagentMaxSelections because they always have the identical value.
nxagentClipboardAtom -> serverCLIPBOARD
nxagentTimestampAtom -> serverTIMESTAMP

This is to match the names of the other server atom variables.
we reference lastSelectionOwner[nxagentClipboardSelection].selection everywhere.
The second parameter was always NULL, so remove it. Also remove some
debugging output which distracts while debugging as the function is
called from ProcChangeProperty for _every_ property, also non-clipboard
related ones.
This is not a functional change, it only helps in clearer debugging
output.
serverClientCutProperty is the external equivalent of the internal
clientCutProperty. We need it on the server side, too, because we use
the property on the serverWindow on the real X server. We could
(mis)use serverCutProperty here but this might introduce race
conditions when both sides request selections simultaneously.
add new debug output, extend existing, drop meaningless
@sunweaver sunweaver force-pushed the uli42:pr/clipboard_overhaul branch from 61e7cec to 72c0224 Sep 29, 2019
Copy link
Member

left a comment

Nice! Merging...

@sunweaver sunweaver merged commit 72c0224 into ArcticaProject:3.6.x Sep 29, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
sunweaver added a commit that referenced this pull request Sep 29, 2019
Attributes GH PR #846: #846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.