Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking Settings #11

Closed
jcgruenhage opened this issue Nov 28, 2016 · 2 comments
Closed

Reworking Settings #11

jcgruenhage opened this issue Nov 28, 2016 · 2 comments

Comments

@jcgruenhage
Copy link

@jcgruenhage jcgruenhage commented Nov 28, 2016

Hello,

I'm currently rewriting the settings, since I noticed that there is a lot of crossed out text in the current SettingsActivity, using Fragments. While I'm at that, I thought, I could also merge the stuff from my fork, that basically just removes all UI and exports everything regularily, to unify that. My proposal for the settings structure:

  • Export Preferences
    • Export Path
    • Subdirectory structure for albums
    • Subdirectory structure for playlists
    • MP3 metadata
    • Maximum artwork size
  • Automation
    • Enable automatic export (Checkbox)
    • Export Interval
    • Require Charging
    • Require Unmetered Network
    • About this feature (link to a blog post)
  • About
    • Thanks/Credits
    • Project Homepage (I'll probably create something for this too, since the original dev seems to have suspended his work on this project)
    • Build date
    • Version number

@ALL, I'm open for suggestions ^^

jcgruenhage referenced this issue in ddonuts4/PlayMusicExporter Nov 28, 2016
@jcgruenhage

This comment has been minimized.

Copy link
Author

@jcgruenhage jcgruenhage commented Nov 28, 2016

Made some progress, setting the paths does work now, but there still is a lot of work to do, because @Arcus92 did some things in a way that is not easily compatible with the new PreferenceFragment stuff, so most of the pref code needs to be rewritten. I'll commit and push, once the rest of the preferences work again.

The automated export requires API 21 (scheduling is done with jobs and the ExportAllService expects DocumentFiles), so I'll have to figure out how to hide that on KitKat and lower..

@jcgruenhage

This comment has been minimized.

Copy link
Author

@jcgruenhage jcgruenhage commented Dec 30, 2016

Made some progress, and since this repo is dead, I will continue in my repo from now on.

See playmusicexporter/playmusicexporter@4b9b042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.