Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Parameter menu to console #659

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@Akshath-Singhal
Copy link
Contributor

commented Aug 5, 2019

Parameter menu added to the console

@tridge @peterbarker Please let me know if anything else needs to be added to the menu.

@Akshath-Singhal Akshath-Singhal changed the title Added GUI Parameter Editor Added Parameter menu to console Aug 5, 2019

@tridge

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

getting a lot of errors:
Traceback (most recent call last):
File "/home/tridge/.local/lib/python2.7/site-packages/MAVProxy-1.8.8-py2.7.egg/EGG-INFO/scripts/mavproxy.py", line 850, in periodic_tasks
File "build/bdist.linux-x86_64/egg/MAVProxy/modules/mavproxy_paramedit/init.py", line 38, in idle_task
if self.pe_main.needs_unloading:
AttributeError: 'ParamEditorMain' object has no attribute 'needs_unloading'
Traceback (most recent call last):
File "/home/tridge/.local/lib/python2.7/site-packages/MAVProxy-1.8.8-py2.7.egg/EGG-INFO/scripts/mavproxy.py", line 850, in periodic_tasks
File "build/bdist.linux-x86_64/egg/MAVProxy/modules/mavproxy_paramedit/init.py", line 38, in idle_task
if self.pe_main.needs_unloading:
AttributeError: 'ParamEditorMain' object has no attribute 'needs_unloading'

@Akshath-Singhal

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

getting a lot of errors:
Traceback (most recent call last):
File "/home/tridge/.local/lib/python2.7/site-packages/MAVProxy-1.8.8-py2.7.egg/EGG-INFO/scripts/mavproxy.py", line 850, in periodic_tasks
File "build/bdist.linux-x86_64/egg/MAVProxy/modules/mavproxy_paramedit/init.py", line 38, in idle_task
if self.pe_main.needs_unloading:
AttributeError: 'ParamEditorMain' object has no attribute 'needs_unloading'
Traceback (most recent call last):
File "/home/tridge/.local/lib/python2.7/site-packages/MAVProxy-1.8.8-py2.7.egg/EGG-INFO/scripts/mavproxy.py", line 850, in periodic_tasks
File "build/bdist.linux-x86_64/egg/MAVProxy/modules/mavproxy_paramedit/init.py", line 38, in idle_task
if self.pe_main.needs_unloading:
AttributeError: 'ParamEditorMain' object has no attribute 'needs_unloading'

@tridge Can you list the commands you used? Did you use --load-module?

@Akshath-Singhal Akshath-Singhal force-pushed the Akshath-Singhal:parameditor branch from 8ab9a0e to 69a5c7d Aug 5, 2019

Parameter menu added to console
Console menu added
Corrected file extension used in parameditor

@Akshath-Singhal Akshath-Singhal force-pushed the Akshath-Singhal:parameditor branch from 69a5c7d to 250171b Aug 5, 2019

@tridge

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

I was using the menu to load the module.
I think it is just a race in thread creation. I've pushed a fix your branch

@tridge tridge merged commit 6fad368 into ArduPilot:master Aug 5, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.