Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLIGHT mode #662

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@Akshath-Singhal
Copy link
Contributor

commented Aug 13, 2019

Highlight current flight mode. Resolved bugs on setting parameters and redraw based on search key.

@Akshath-Singhal

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@peterbarker @tridge I am working on adding categorical search of parameters. Using 'FLTMODE' in search key provides the desired behaviour for setting flight modes as we discussed earlier. Highlighting the parameter name makes it intuitive to use and does not confuse with parameter change which highlights the value column. Please have a look.
Screenshot from 2019-08-13 22-30-56

@tridge
Copy link
Contributor

left a comment

really nice idea! just a few details to fix up

@Akshath-Singhal Akshath-Singhal force-pushed the Akshath-Singhal:parameditor branch from 338639f to 36044cb Aug 18, 2019

FLIGHT mode
Highlight current flight mode. Resolved bugs on setting parameters and redraw based on search key.

@Akshath-Singhal Akshath-Singhal force-pushed the Akshath-Singhal:parameditor branch from 36044cb to ac954e4 Aug 19, 2019

@tridge
tridge approved these changes Aug 19, 2019

@tridge tridge merged commit fa2b9de into ArduPilot:master Aug 19, 2019

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details
@tridge

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

I have merged, but I would like to see a drop-down list of parameter categories that limits the parameters displayed (shortcut to search but on param names only)
So user can select "FlightModes" in the drop down
Then also have "Compass", "INS", "Battery" and other key categories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.