Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameditor: Categorical search of parameters #673

Merged
merged 1 commit into from Aug 24, 2019

Conversation

@Akshath-Singhal
Copy link
Contributor

commented Aug 23, 2019

Added categorical search of parameters with a predefined list of categories.

@tridge Might need a work around for Flight Modes on Rover. Using only MODE displays extra parameters.

@Akshath-Singhal Akshath-Singhal force-pushed the Akshath-Singhal:parameditor branch from 20b14ca to 2ab3289 Aug 23, 2019

@Akshath-Singhal

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

@tridge The second commit basically deals with the special case of modes in ROVERS. I will squash the commits once we agree on using this method. Also you might want to list the categories to be added to the dropdown menu here.

@Akshath-Singhal Akshath-Singhal force-pushed the Akshath-Singhal:parameditor branch 2 times, most recently from 72790d3 to b22e183 Aug 23, 2019

@Akshath-Singhal

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

@tridge Both the search key and the category complements each other now. Seems ready to be merged to me.

@tridge

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

the categories work, but I think the drop-down should only have the bit before the ':', so "PosControl" not "PosControl:VEL_,POS_,WPNAV_,RTL_"
It is also using substring searches, so the POS_ in PosControl is finding EK2_POS_I_GATE. Substring searches are great for the search box, but not good in the dropdown.
I've also noticed that the param editor is failing completely under python3 (specifically 3.6.8 on ubuntu 18.04). The module loads but doesn't display anything.
I also see some bugs by running flake8 over the code. For example:

MAVProxy/modules/mavproxy_paramedit/param_editor.py:219:12: F821 undefined name 'ParamEditorModule'

Parameter Category Search
Added drop-down list for categorical search of parameters

@Akshath-Singhal Akshath-Singhal force-pushed the Akshath-Singhal:parameditor branch from b22e183 to f2d6890 Aug 24, 2019

@Akshath-Singhal

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

the categories work, but I think the drop-down should only have the bit before the ':', so "PosControl" not "PosControl:VEL_,POS_,WPNAV_,RTL_"
It is also using substring searches, so the POS_ in PosControl is finding EK2_POS_I_GATE. Substring searches are great for the search box, but not good in the dropdown.
I've also noticed that the param editor is failing completely under python3 (specifically 3.6.8 on ubuntu 18.04). The module loads but doesn't display anything.
I also see some bugs by running flake8 over the code. For example:

MAVProxy/modules/mavproxy_paramedit/param_editor.py:219:12: F821 undefined name 'ParamEditorModule'

Corrected the typo in Flake8. Though it had no effect.
Python3 error was due to unbuffered I/O for /dev/null, it has been corrected.
Displays only upto ':' for category now, substring search removed from categories.

@tridge tridge merged commit 3094d90 into ArduPilot:master Aug 24, 2019

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details
@tridge

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

much better, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.