Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter/CameraGimbal: Change from CH to RC, RC to SERVO #1175

Merged
merged 4 commits into from Jul 24, 2019

Conversation

muramura
Copy link
Contributor

  1. I change from CH to RC. It became a radio control from the channel.
  2. I change from RC to SERVO. It distinguishes RC and SERVO.
  3. When SERVO is specified by the camera trigger of the camera gimbal, the setting item of the camera trigger can be changed.

@Arne-W
Copy link
Contributor

Arne-W commented Jul 15, 2019

@muramura Thank you for participating to AP2. I will do the review as soon as possible.

Copy link
Contributor

@Arne-W Arne-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be possible that this file should not be in the PR?
src/ui/configuration/CameraGimbalConfig.cc.bug
Would be nice if you could check that.

@muramura
Copy link
Contributor Author

muramura commented Jul 21, 2019

@Arne-W san...
Thanks for your comment.
The following file is unnecessary.
I will delete it.

rc/ui/configuration/CameraGimbalConfig.cc.bug

@Arne-W Arne-W merged commit 48c13a2 into ArduPilot:master Jul 24, 2019
@Arne-W
Copy link
Contributor

Arne-W commented Jul 24, 2019

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants