Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_WindVane: mini onion #11344

Merged
merged 5 commits into from May 27, 2019

Conversation

@IamPete1
Copy link
Contributor

commented May 13, 2019

This moves AP_WindVane to a front end - back end style driver. This is the first time I have done something like this, so would be great to have some feed back.

I think my includes may be wrong, although it seems to work, in SITL anyway. Next step is to flash to a board and see if the other backends work.

@IamPete1 IamPete1 requested review from tridge and rmackay9 May 13, 2019

APMrover2/GCS_Mavlink.cpp Outdated Show resolved Hide resolved

@IamPete1 IamPete1 force-pushed the IamPete1:windvane_tidyup branch from fe24776 to f61243c May 13, 2019

@rmackay9

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Looks pretty good to me! nicely done!

@rmackay9
Copy link
Contributor

left a comment

Looking good, I think if it was rebased, tested and shown to work (in SITL and with one of the real device) it would probably be read to be merged.

@IamPete1 IamPete1 force-pushed the IamPete1:windvane_tidyup branch from f61243c to 5b9a016 May 15, 2019

@IamPete1

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

I have tested the SITL backend and added RPM and airspeed updates to the Sailboat SITL so the airspeed and RPM wind vane types can be tested using the pre-exisiting RPM and Airspeed SITL back ends. I will test remaining backends on real hardware.

@IamPete1 IamPete1 force-pushed the IamPete1:windvane_tidyup branch from 5b9a016 to e6581d1 May 16, 2019

@IamPete1

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

I forgot to check for nullprt drivers, I have added that and tested the remaining back-ends on a pixhawk1. All is working as it should.

@IamPete1 IamPete1 marked this pull request as ready for review May 16, 2019

@rmackay9 rmackay9 merged commit fbc2650 into ArduPilot:master May 27, 2019

5 checks passed

ArduPilot.ardupilot Build #20190516.17 succeeded
Details
ArduPilot.ardupilot (Cygwin SITL build) Cygwin SITL build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@rmackay9

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Merged, thanks!

@IamPete1 IamPete1 removed the DevCallTopic label May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.