Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Windvane: Add support for NMEA wind vane types #11432

Merged
merged 4 commits into from Jun 3, 2019

Conversation

@IamPete1
Copy link
Contributor

commented May 28, 2019

This add support for NMEA 0183 sensors using the mwv message type

Tested using a Calypso Wired Standard Ultrasonic sensor.

https://calypsoinstruments.com/shop/product/ultrasonic-wired-standard-81

This is my first go at a digital protocol, it is based on the NMEA rangfinder type. Seems to work and return sensible numbers.

@IamPete1 IamPete1 requested review from tridge and rmackay9 May 28, 2019

@WickedShell

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Not a thing to do here by any means, but we really need to do the cleanup one day of having a single generic NMEA parser, and then have a callback for term complete that each use case can set. We now have GPS, rangefinders, and wind sensors that are all running basically the same NMEA parser.

Anyways this isn't a blocker/hold up/request for any change. I just wanted to note it somewhere :)

@rmackay9

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

this looks pretty good to me.. i haven't done a detailed check of all the logic but it works on the real hardware?

@rmackay9

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

@WickedShell, maybe we should merge this PR first so that we at least get rid of the duplicate hex_to_char function?

@IamPete1

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

@rmackay9 Yep tested on KakuteF7 with rs232 converter. Get sensible numbers for speed and direction. Not tested in on the water yet.

@rmackay9 rmackay9 merged commit 4900386 into ArduPilot:master Jun 3, 2019

5 checks passed

ArduPilot.ardupilot Build #20190528.14 succeeded
Details
ArduPilot.ardupilot (Cygwin SITL build) Cygwin SITL build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@rmackay9

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.