Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kakute f7 mini #11452

Closed
wants to merge 3 commits into from

Conversation

@Dronotique
Copy link

Dronotique commented May 30, 2019

Based on Kakute F7
Replace SD Card with Flash Memory feature

@Dronotique Dronotique mentioned this pull request May 30, 2019
@Dronotique

This comment has been minimized.

Copy link
Author

Dronotique commented May 30, 2019

should fix #11380

@OXINARF OXINARF requested a review from tridge Jun 20, 2019
@OXINARF

This comment has been minimized.

Copy link
Member

OXINARF commented Jun 20, 2019

@Dronotique Thank you for your first contribution! However, this needs a bit of work:

  • merge commits aren't allowed, you need to rebase on master
  • you are changing entire files (likely replacing spaces with tabs or something like that)
  • commit messages need to follow our format

Please see our contribution guidelines at http://ardupilot.org/dev/docs/submitting-patches-back-to-master.html

Also, if you need any help, we are available to help in Gitter chat too (http://gitter.im/ArduPilot/ardupilot).

@khancyr Please post a comment when you mark something as needing work, otherwise OP wouldn't know what is wrong (this is specially true for new contributors).

@R-Lefebvre

This comment has been minimized.

Copy link
Contributor

R-Lefebvre commented Nov 29, 2019

Closing PR. Comments never addressed, and Andy Piper already got logging working in Master.

@R-Lefebvre R-Lefebvre closed this Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.