Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_SITL: set initial PWM values to a flag value #12278

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@peterbarker
Copy link
Contributor

commented Sep 12, 2019

These should never be used. Setting them to a flag value may give a
hint to someone trying to debug a problem in the future.

Suggested as part of discussions with @jaxxzer in #8961

@jaxxzer
Copy link
Member

left a comment

Maybe mention that it is because the values should be overwritten before they are used.

AP_HAL_SITL: set initial PWM values to a flag value
These should never be used.  Setting them to a flag value may give a
hint to someone trying to debug a problem in the future.

@peterbarker peterbarker force-pushed the peterbarker:pr/pwm-flag-value branch from 331afc2 to 61cabd6 Sep 12, 2019

@peterbarker peterbarker merged commit 1735563 into ArduPilot:master Sep 12, 2019

4 checks passed

ArduPilot.ardupilot Build #20190912.25 succeeded
Details
ArduPilot.ardupilot (Cygwin SITL build) Cygwin SITL build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@peterbarker

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@jaxxzer done

@peterbarker peterbarker deleted the peterbarker:pr/pwm-flag-value branch Sep 13, 2019

@rmackay9

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

I think this went in without enough review 'cuz from what i can see it's broken SITL because all the user inputs default to crazy low values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.