Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ChibiOS: hardware definition for Kakute F7 Mini #12520

Merged
merged 2 commits into from Oct 12, 2019

Conversation

@andyp1per
Copy link
Contributor

commented Oct 8, 2019

ChibiOS hardware definitions and bootloader for the Kakute F7 Mini

https://shop.holybro.com/kakute-f7-mini_p1133.html

Board id 145 comes from https://github.com/ArduPilot/Bootloader/blob/master/board_types.txt

@andyp1per andyp1per force-pushed the andyp1per:pr-kakute-f7-mini branch 2 times, most recently from b983307 to e7e5c2c Oct 9, 2019
@andyp1per andyp1per marked this pull request as ready for review Oct 9, 2019
@andyp1per

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

@tridge this seems to be working now and I have done the bootloader dance as well

@andyp1per andyp1per force-pushed the andyp1per:pr-kakute-f7-mini branch from e7e5c2c to c7f7d2b Oct 10, 2019
@vierfuffzig

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2019

@andyp1per as suggested on discuss forum you might want to reference existing KakuteF7 hwdef and just redefine apj board ID, flash defines and maybe fix UART order match hardware port mapping reg. UARTS 6 and 7.

@tridge

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2019

looks good to me!
@vierfuffzig I'm OK with them being separate. There are quite a few changes between them. Either approach is OK for this level of changes I think

Copy link
Contributor

left a comment

Only one thing missing - add it to Tools/scripts/build_binaries.py so it auto-builds for firmware server

@vierfuffzig

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2019

@tridge as far as i can see right now it's an exact copy of the non-mini version except for using flash instead of SD for logging. sure don‘t want to nitpick, just wonder if i‘m missing something.

plus i really do think aligning runtime SERIAL port mapping to match hardware ports / silkscreen imprints adds major convenience and reduces support / documentation effort a lot.

@andyp1per

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2019

How do I undef an SPIDEV declaration if I am to do it this way?

Current changes are:

  • UART order / mapping to be intuitive
  • Dataflash device / logging
  • Board id
  • Battery monitor scaling
  • Undefine UART7 TX pin
  • Turn off HAL_MINIMIZE_FEATURES
@andyp1per andyp1per force-pushed the andyp1per:pr-kakute-f7-mini branch from c7f7d2b to d7b952f Oct 12, 2019
@andyp1per

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2019

Ok, I have done the include thing for the bootloader as it is identical apart from the board id. That seems to work great as I ended up with an identical binary file.

I have kept the other file separate and made the changes above.

@tridge
tridge approved these changes Oct 12, 2019
@tridge tridge merged commit 16c9649 into ArduPilot:master Oct 12, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ArduPilot.ardupilot Build #20191012.7 succeeded
Details
ArduPilot.ardupilot (Cygwin SITL build) Cygwin SITL build succeeded
Details
semaphoreci The build passed on Semaphore.
Details
@andyp1per

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2019

Thanks!

@andyp1per andyp1per deleted the andyp1per:pr-kakute-f7-mini branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.