Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
RC_Channel: put options in numerical order and add missing options for Rover #12804
This PR includes two changes:
This has been tested on a CubeOrange:
On Fri, 8 Nov 2019, Randy Mackay wrote: * a non-functional reorder of the case statement in each of the RC_Channel::init_aux_function() methods for the RC_Channel library and each vehicle. This re-order may cause some annoyance as we try to backport options to the stable branches but long lists (of functions, cases, etc) in seemingly random order make spotting errors difficult. Let's try and use either numerical or alphabetical ordering.
I'm wondering if we'd be better off with alphabetic here. - it's easier to keep things in order (as you just ask your editor to sort all of the lines....) - it's easier to find an entry in the list visually
peterbarker merged commit
Nov 12, 2019
4 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.