Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_InertialSensor: correct loop rate on BMI055 #12890

Merged
merged 1 commit into from Dec 9, 2019

Conversation

@andyp1per
Copy link
Contributor

andyp1per commented Nov 25, 2019

Clean up setting of loop rate on BMI055 and BMI088

The BMI088 change is simply a naming thing - no functional change
The BMI055 change is something that looks obviously wrong, @tridge to confirm

…oop rate on BMI055 and BMI088
@andyp1per andyp1per requested a review from tridge Nov 25, 2019
@CraigElder CraigElder removed the DevCallTopic label Dec 2, 2019
@rmackay9

This comment has been minimized.

Copy link
Contributor

rmackay9 commented Dec 3, 2019

We discussed this on the DevCall and I think the outcome was that @tridge and @andyp1per would discuss offline some morning (Canberra time)

@andyp1per

This comment has been minimized.

Copy link
Contributor Author

andyp1per commented Dec 7, 2019

I can confirm that the gyro/accel rates are correct for the BMI088.

@tridge I believe you can now merge this

image

@tridge tridge merged commit 7e35622 into ArduPilot:master Dec 9, 2019
4 checks passed
4 checks passed
ArduPilot.ardupilot #20191125.22 succeeded
Details
ArduPilot.ardupilot (Cygwin SITL build) Cygwin SITL build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Plane 4.0 Backports
  
Awaiting triage
Rover 4.0 backports
Awaiting triage
Copter 4.0 backports
Awaiting triage
4 participants
You can’t perform that action at this time.