Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add moretext char extension to statustext message #12937
Sample output from the included debug commit:
So there are several cons to this commit:
Advantages with this approach vs
I'm still not sure I don't prefer my
statustext extension concept better, but tridge suggests it suffers from the "need-to-wait-for-chunks before showing anything" problem, and those chunks may never come. You'd need a timer running to timeout waiting for the last chunk before display....
Yeah I'm torn. I want longer status texts for getting compiler errors down, but on the one hand this eats a lot of RAM (versus the current plan of just send up to like 5 messages in a row).
The other concern I have is, given the deployment time on GCS's coping with this, and having to support MAVLink 1 means we would still have to have the critical parts of the message in the first 50 bytes. The extension one to spam more STATUSTEXT messages means that MAVLink 1 GCS's loose no data if they don't do single reassembly. And either way MAVLink2 GCS's will have to be modified to take advantage of the extension in either scenario. (the chunk stuff also actually extends to much longer messages easily whereas increasing the blob size doesn't help us there)