Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL_ChibiOS: fixed stdout in early startup bug #13552

Merged
merged 1 commit into from Feb 12, 2020

Conversation

@tridge
Copy link
Contributor

tridge commented Feb 11, 2020

this caused a failure to boot on some boards if they tried to print
messages in early startup code before hal was initialised

thanks to @Shadowru for reporting the issue

#ifdef HAL_USB_PRODUCT_ID
setup_usb_strings();
#if HAL_USE_SERIAL_USB == TRUE
usb_initiailse();

This comment has been minimized.

Copy link
@kd0aij

kd0aij Feb 11, 2020

Contributor

typo

This comment has been minimized.

Copy link
@tridge

tridge Feb 12, 2020

Author Contributor

you want the american spelling of initialise?

This comment has been minimized.

Copy link
@tridge

tridge Feb 12, 2020

Author Contributor

ahh, now I see it. Amazing how blind I can be to spelling errors. Fixed

This comment has been minimized.

Copy link
@kd0aij

kd0aij Feb 12, 2020

Contributor

:) I'll be more specific next time

this caused a failure to boot on some boards if they tried to print
messages in early startup code before hal was initialised

thanks to @Shadowru for reporting the issue
@tridge tridge force-pushed the tridge:pr-stdio-init branch from 02937f2 to ee9a3b6 Feb 12, 2020
@tridge tridge merged commit e8ab35a into ArduPilot:master Feb 12, 2020
4 checks passed
4 checks passed
ArduPilot.ardupilot Build #20200212.1 succeeded
Details
ArduPilot.ardupilot (Cygwin SITL build) Cygwin SITL build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@rmackay9

This comment has been minimized.

Copy link
Contributor

rmackay9 commented Feb 12, 2020

I think this may have broken master. At least on my cube black I don't seem to be able to connect with a USB cable with this commit included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.