New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autotest: make RTL and Land wait a little more verbose, don't use raw reboot on fly_battery_failsafe #14882
Conversation
@peterbarker some fixs for the autotest. Could have a look at them. nothing worring. |
713dc40
to
b0928d6
Compare
comments addressed and ready to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several good changes in here.
It's a bit of a pity they're all mixed in as it means I'm reviewing perfectly good changes multiple times, and they're being held up for other stuff :-)
One thing you may not have been aware of - we've had CI failures because of too much log output. Something to bare in mind.
Tools/autotest/arducopter.py
Outdated
except Exception as e: | ||
ex = e | ||
|
||
self.set_parameter('BATT_LOW_VOLT', 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use a context here rather than assuming this list of parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was done like that so I did it the same way.
I can use the context
I have split the PR into multiple to not hold the ready ones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tweaked the commit messages.
Looks like the check for altitude needs to accept that the vehicle might start off on the ground. |
796dc28
to
ccfa69d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There still appears to be a new failure in the heli test in this PR.
I've rebased this and taken out the expectation of the statustext. That can reappear later if you can get the heli test passing. |
Merged, thanks! |
also correct flip test that wasn't resetting the attitude correctly