New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mavlink: Update to HEAD from master branch and add upstream updates f… #14922
Mavlink: Update to HEAD from master branch and add upstream updates f… #14922
Conversation
libraries/GCS_MAVLink/GCS_Common.cpp
Outdated
{ | ||
const AP_Baro &barometer = AP::baro(); | ||
|
||
bool have_data = false; | ||
|
||
float press_abs = 0.0f; | ||
float temperature = 0.0f; | ||
float temperature = 0.0f; // Absolute pressure temperature | ||
float temperature_press_diff = 0.0f; // TODO: Differential pressure temperature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be UINT16_MAX if we don't have it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an extension though, so you can't tell if 0 is actually 0C or max... Usually with extensions you have to special case that 0 means unknown. (And if we don't have it a value of 0 is more amenable to packet trimming)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, your right, I was lead astray ;) , mavlink/mavlink#1429 (comment) Can change the comment to say 0 is the special case I guess.
This is pending some other mavlink and ardupilot PR'S. Do not merge yet |
7a9b670
to
07225a4
Compare
The other PRs have been merged, this one can be merged now, after ArduPilot/mavlink#132 |
@tridge all test passed, this one is also ready to go in |
…rom up-to 20200401
07225a4
to
110aa6d
Compare
I've merged the dependent submodule change and force pushed this for CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go in once CI passes
All CI tests pass now. Thanks Tridge |
Merged, thanks! |
…rom 20200401
This is to test if the upstream changes break the code
This can only be merged after the #14920