Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Baro: auto-set field elevation from origin #20867

Merged
merged 1 commit into from Dec 19, 2022

Conversation

tridge
Copy link
Contributor

@tridge tridge commented May 29, 2022

This sets the active baro field elevation from the origin altitude if not set by the user. This should make baro altitude better match aviation altitude for all users, without having to setup the parameter on each flights
ping @rbeall
tested successfully on a CubeOrange plane with 4 flights

@tridge tridge force-pushed the pr-baro-field-elev-auto branch 2 times, most recently from 8133941 to 0afb20a Compare July 4, 2022 05:49
libraries/AP_Baro/AP_Baro.cpp Show resolved Hide resolved
@tridge tridge force-pushed the pr-baro-field-elev-auto branch 2 times, most recently from 2f3d65e to e468c6c Compare July 12, 2022 05:34
@tridge tridge force-pushed the pr-baro-field-elev-auto branch 2 times, most recently from 3312e94 to e05eb5a Compare July 21, 2022 00:39
@peterbarker
Copy link
Contributor

@tridge this has reliably broken Tracker's SetHome test.

I'd place a small wager on it breaking vehicles with ARMING_REQUIRE 0 given the nature of one of the patches in here, too.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants