Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow debug console to be used for other protocols #6761

Closed
wants to merge 3 commits into from

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Aug 13, 2017

This allows the debug console on FMUv2 and FMUv3 to be used for other serial protocols, by setting SERIAL5_PROTOCOL to an appropriate value.
fixes issue #6692

this allows SERIAL5_PROTOCOL to be set on FMUv2 and FMUv3 for use by
other protocols
added flag for nsh exit
@proficnc
Copy link
Contributor

Thankyou Tridge!

@robustini
Copy link
Contributor

robustini commented Aug 13, 2017

Thanks you Andrew! Number One!

@jmachuca77
Copy link
Contributor

jmachuca77 commented Aug 13, 2017 via email

@WickedShell
Copy link
Contributor

@tridge If I'm following right the port still starts up as NSH first with some prints from the PX4 layer, then once the APM task is launched it's killed?

@proficnc
Copy link
Contributor

We should ensure the comments that come with the parameter on the ground stations reflect this.

And we should engage the community to ensure this has no effect on various devices.

That way we can just swap devices to a suitable port.

This is very good!

@tridge
Copy link
Contributor Author

tridge commented Aug 13, 2017

@tridge If I'm following right the port still starts up as NSH first with some prints from the PX4 layer, then once the APM task is launched it's killed?

that's right. The only way we could avoid that is to have some persistent data that can be read by the very early startup code that indicates that the nsh debug port is disabled.
Given that you are free to arrange your UARTs in any order you like I don't think this is a big issue. Many (most?) devices won't care if they get some debug stuff at startup, so just choose one for SERIAL5 that doesn't care, such as a telemetry radio.

Copy link
Member

@OXINARF OXINARF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It could also be implemented for Pixracer, but that has 5 ports already, should be enough for most use cases.

@robustini
Copy link
Contributor

Please merge this commits...

@tridge
Copy link
Contributor Author

tridge commented Aug 28, 2017

merged

@tridge tridge closed this Aug 28, 2017
@tridge tridge added this to the Plane v3.8.1 milestone Aug 28, 2017
@PlanetKrikkit
Copy link

Forgive my ignorance, but I would like to user serial 5 to stream Mavlink to an Alexmos gimbal controller. The gimbal controller manual recommends some message stream rate values, but although I can set serial5_protocol to be '1' i see no sr5_xxx parameters (or sr4_ for that matter) to allow me to configure the messages/rates required. Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants