Plane: Small cleanup to quadplane const (and clarity) #9270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
approved these changes
Aug 27, 2018
| @@ -483,7 +483,7 @@ bool QuadPlane::setup(void) | |||
| } | |||
|
|
|||
| if (hal.util->available_memory() < | |||
| 4096 + sizeof(*motors) + sizeof(*attitude_control) + sizeof(*pos_control) + sizeof(*wp_nav)) { | |||
There was a problem hiding this comment.
Why don't we just malloc, check the result then look at the amount of free memory?
| if (!motor_at_lower_limit) { | ||
| landing_detect.lower_limit_start_ms = 0; | ||
| return false; | ||
| } else if (landing_detect.lower_limit_start_ms == 0) { |
tridge
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small set of sanity patches to the quadplane code that I came across while trying to address other things. In no particular order it does the following things:
constto a number of functions, primarily intended to help track what can side effect.QuadPlane::should_relax()