New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more than 1 level of dialect inclusion #248

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@hamishwillee
Copy link
Contributor

hamishwillee commented Nov 30, 2018

The toolchain only supports including 1 level of dialect include nesting. This PR allows include files to be nested up to 5 levels deep (but will stop earlier if no new files are detected).

Current set of dialect files are unchanged by this.

Show resolved Hide resolved generator/mavgen.py Outdated
@hamishwillee

This comment has been minimized.

Copy link
Contributor Author

hamishwillee commented Nov 30, 2018

@peterbarker When you have chance to review ...

@OXINARF OXINARF requested review from tridge and peterbarker Dec 4, 2018

@hamishwillee

This comment has been minimized.

Copy link
Contributor Author

hamishwillee commented Dec 20, 2018

Can this please get reviewed?

@hamishwillee

This comment has been minimized.

Copy link
Contributor Author

hamishwillee commented Jan 2, 2019

Ping.

Show resolved Hide resolved generator/mavgen.py Outdated
Show resolved Hide resolved generator/mavgen.py Outdated
@amilcarlucas
Copy link
Contributor

amilcarlucas left a comment

Nice

@hamishwillee

This comment has been minimized.

Copy link
Contributor Author

hamishwillee commented Feb 5, 2019

Great. @amilcarlucas appreciate you chasing this in the dev call.

@hamishwillee

This comment has been minimized.

Copy link
Contributor Author

hamishwillee commented Feb 12, 2019

Hi @amilcarlucas - any luck on getting review on this in devcall?

@amilcarlucas

This comment has been minimized.

Copy link
Contributor

amilcarlucas commented Feb 12, 2019

@hamishwillee sorry did not attend the meeting this week :(

@hamishwillee

This comment has been minimized.

Copy link
Contributor Author

hamishwillee commented Feb 12, 2019

No worries @amilcarlucas . This is in no way urgent.

@tridge
Copy link
Contributor

tridge left a comment

nice!
please make it skip an xml if its already included
Also, please test that this produces no change in headers for ardupilot xml

for i in x.include:
fname = os.path.join(os.path.dirname(x.filename), i)

# Only parse new include files

This comment has been minimized.

@hamishwillee

hamishwillee Feb 20, 2019

Author Contributor

please make it skip an xml if its already included

@tridge Already does - here.

@hamishwillee

This comment has been minimized.

Copy link
Contributor Author

hamishwillee commented Feb 20, 2019

@tridge

Also, please test that this produces no change in headers for ardupilot xml

I retested that for Python and C for all dialects. No changes, because only 1 level of inclusion has been used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment