New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested fragment leak when replace #24

Closed
CherryPerry opened this Issue Oct 6, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@CherryPerry
Contributor

CherryPerry commented Oct 6, 2016

I have fragment with view pager with fragments. Each of them contains presenter. When this fragment is replaced with another one, only fragment's presenter that contains view pager is destroyed, but nested fragment's presenters not.

Demonstration of leak with possible fix

@CherryPerry

This comment has been minimized.

Contributor

CherryPerry commented Oct 7, 2016

I think, it is required to fix default android SDK fragment too, but I have not checked this problem yet.

@senneco senneco self-assigned this Oct 11, 2016

@senneco

This comment has been minimized.

Member

senneco commented Oct 11, 2016

mvp-android with MvpFragment fixed too in 1.0.2

@senneco senneco closed this Oct 11, 2016

@senneco senneco added the bug label Nov 2, 2016

@NoNews

This comment has been minimized.

NoNews commented Dec 19, 2016

@senneco
What about MvpApKompatFragment? It also fixed?

@senneco

This comment has been minimized.

Member

senneco commented Dec 20, 2016

It has been fixed a long time ago too =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment