Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging too many errors on containers initialization #15

Open
lsantire opened this issue Mar 19, 2021 · 0 comments
Open

Avoid logging too many errors on containers initialization #15

lsantire opened this issue Mar 19, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@lsantire
Copy link
Collaborator

lsantire commented Mar 19, 2021

Describe the bug
The docker containers usually log some errors when starting. This happens because some parts of the system, like the database and rabbitmq, refuse the connection attempts made by the backend, the engine and the packer-writer. After some short time, the database and rabbitmq become ready to accept connections and everything start working fine. However, it would be better to avoid logging these initial errors as it can be confusing.

To Reproduce
Steps to reproduce the behavior:

  1. Initialize docker containers with "docker-compose up -d"
  2. Check the logs of the containers, for example: "docker logs backend"
  3. Visualize error logs related with sqlalchemy and rabbitmq connections.

Expected behavior
Each service should try to be initialized a fixed number of times, without logging any errors between different attempts, and only if all these attempts fail, then an error should be logged and the initialization aborted.

@lsantire lsantire added bug Something isn't working dev-ops and removed dev-ops labels Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant