'setupEvents' method moved to event delegation (issue josecebe#75 fixed)

Arifshariar7 · Sep 25, 2016 · e1adabf · e1adabf
1 parent 9e2b60e
commit e1adabf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/examples/index.html b/examples/index.html
@@ -19,13 +19,12 @@
         var obj = $('#pagination').twbsPagination({
             totalPages: 35,
             visiblePages: 10,
-            href: true,
-            pageVariable: 'page',
             onPageClick: function (event, page) {
-                console.info(page);
+                console.info(page + ' (from options)');
             }
+        }).on('page', function (event, page) {
+            console.info(page + ' (from event listening)');
         });
-        console.info(obj.data());
     });
 </script>
 </body>

diff --git a/jquery.twbsPagination.js b/jquery.twbsPagination.js
@@ -210,18 +210,14 @@
 
         setupEvents: function () {
             var _this = this;
-            this.$listContainer.find('li').each(function () {
+            this.$listContainer.off('click').on('click', 'li', function (evt) {
                 var $this = $(this);
-                $this.off();
                 if ($this.hasClass(_this.options.disabledClass) || $this.hasClass(_this.options.activeClass)) {
-                    $this.on('click', false);
-                    return;
+                    return false;
                 }
-                $this.click(function (evt) {
-                    // Prevent click event if href is not set.
-                    !_this.options.href && evt.preventDefault();
-                    _this.show(parseInt($this.data('page')));
-                });
+                // Prevent click event if href is not set.
+                !_this.options.href && evt.preventDefault();
+                _this.show(parseInt($this.data('page')));
             });
         },