Refactored and made the code look better #9

RomaDevWorld · 2023-07-20T10:04:20Z

So I basically removed highly deeply nested code
I also reformatted the code using prettier to make it more readable, and ESLint to fix some errors

I recommend you cloning my code and testing it before merging.

Have a good one!

Removed deeply nesting, added some return conditions instead of if/else

events/messageCreate.js

main.js

Arisamiga

Thank you for contributing to the repository! :D

There seem to be some problems that are preventing the bot from running accordingly.

I have outlined some of the problems above but other problems are:

Bot always thinks there is an ongoing ticket and because of that, it doesn't create a channel.
Bot deleting collector even if it exists
Reactions not being handled correctly
eslint not being configured with prettier so it could conflict with prettier
Some of the if statements are incorrectly handled

If these changes worked on your setup please be sure that you are including all the changes 🙂

RomaDevWorld · 2023-07-20T15:48:56Z

I made some changes

Fixed checkMessage in main.js by adding id property to messages.fetch and removing cache between channels.fetch
Fixed message.content.startsWith in messageCreate.ts by adding a singe exclamation mark
Added prettier plugin to .eslintrc.js so it will work properly with prettier

Arisamiga · 2023-07-20T17:51:00Z

events/messageReactionAdd.js

+    if (messageReaction.emoji.name === '📩') {
+      let channelname = `ticket-${user.username}`;
+      channelname = channelname.replace(/\s/g, '-').toLowerCase();
+      if (!messageReaction.message.guild.channels.cache.find((channel) => channel.name === channelname) || !config.one_app) {


This if statement should not have !'s and should not be a ||

Arisamiga

There are still some issues that I have highlighted above but also the following:

There are a lot of if statements that have "!" that shouldn't be there
Bot deleting collector even if it exists
Some of the if statements are incorrectly handled
Reactions are not being handled based on the role

Please be sure to first test it before requesting a review 🙂

RomaDevWorld · 2023-07-20T20:31:50Z

So.. Tell me again, why do you prefer using client.channels.fetch instead of client.channels.cache.get?

The thing is that in the first case if the channel doesn't exist it will throw an error and crash an entire application.
I'll use client.channels.cache.get since it works just fine :)

RomaDevWorld · 2023-07-20T20:43:49Z

Collectors and tickets won't be deleted if they still exist
Only authorized roles and “Admins” can close/delete ticket
The misunderstood "if" statement was fixed and now works as expected.

P.S: I've tested it, and haven't found any issues

Fell free to point me to any new problems you'll find!

Arisamiga · 2023-07-21T13:08:00Z

main.js

+const checkMessage = async (id, channelid) => {
+  const channel = await client.channels.cache.get(channelid);
+  if (!channel) return;
+  const channelMessage = await channel?.messages.fetch(id);


Might want to add a .catch to prevent the application from crashing because if there is an error it is most likely because the message doesn't exist.

if message doesn't exist the channelMessage will just be undefined. No error here.

If the message doesn't exist the channelMessage will crash the application because Discord returns a 404 error code with DiscordAPIError: Unknown Message so I suggest adding a .catch there.

main.js

Arisamiga · 2023-07-21T13:16:18Z

events/messageReactionAdd.js

+    let channel = messageReaction.message.guild.channels.cache.find((channel) => channel.id === messageReaction.message.channel.id);
+    switch (messageReaction.emoji.name) {
+      case '🔒':
+        if (!checkUser(messageReaction.message, user) || !config.allow_user_lock) {


Since this uses "!" you should use "&&" not "||"

Why tho? Am I missing something?

If the user is not authorized to close the channel, or config doesn't allow this then respond with "Only Staff can lock the channels"

Oh, I see.

(Allow users to lock their own tickets)

Arisamiga · 2023-07-21T13:16:31Z

events/messageReactionAdd.js

+        return messageReaction.message.channel.send('Channel Locked 🔒');
+      case '⛔':
+        if (!messageReaction.message.guild.channels.cache.find((c) => c.name.toLowerCase() === channel.name)) return;
+        if (!checkUser(messageReaction.message, user) || !config.allow_user_delete) {


Since this uses "!" you should use "&&" not "||"

Arisamiga

There are some minor issues which I have outlined above!

Also might wanna install the config for prettier: ESLint couldn't find the config "prettier" to extend from. :)

RomaDevWorld · 2023-07-22T07:30:16Z

Made the changes that you mentioned.
Also added nodemon to automatically refresh the application on file save
npm run dev

Arisamiga

Thanks so much for contributing 🙂 Everything is working Great!

RomaDevWorld · 2023-07-22T12:16:12Z

I also recomend you learning and using typescript in your future javascript projects. It can be a little bit hard to learn and understand, but when you do it will make your projects 10x better!

Stay safe!

RomaDevWorld added 6 commits July 20, 2023 12:04

Add: Prettier config

0f82e1c

Add: .gitignore

8ce85fa

Add: ESLint config & lint script

d7233c7

Update: prettier config

0b9beb6

Update: README.md

5535ddb

Update: Several files

cdb89ac

Removed deeply nesting, added some return conditions instead of if/else

Arisamiga added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 20, 2023

Arisamiga self-requested a review July 20, 2023 10:37

Arisamiga reviewed Jul 20, 2023

View reviewed changes

events/messageCreate.js Outdated Show resolved Hide resolved

Arisamiga reviewed Jul 20, 2023

View reviewed changes

main.js Outdated Show resolved Hide resolved

Arisamiga reviewed Jul 20, 2023

View reviewed changes

main.js Outdated Show resolved Hide resolved

Arisamiga requested changes Jul 20, 2023

View reviewed changes

RomaDevWorld added 4 commits July 20, 2023 18:11

Fixed "checkMessage" function in main.js

58c4a4d

Fixed messageCreate prefix issue

3691d5f

Update: eslint config

74cacba

Fix: messageReactionAdd

d2f4d00

RomaDevWorld requested a review from Arisamiga July 20, 2023 15:49

Arisamiga reviewed Jul 20, 2023

View reviewed changes

Arisamiga requested changes Jul 20, 2023

View reviewed changes

Fix: checkMessage now returns message object instead of true or false

6f5ae20

RomaDevWorld added 2 commits July 20, 2023 23:32

Changed channels.fetch to channels.cache.get

31330c0

Fixed incorrect if statement

674cb87

RomaDevWorld requested a review from Arisamiga July 20, 2023 20:44

Arisamiga reviewed Jul 21, 2023

View reviewed changes

main.js Show resolved Hide resolved

Arisamiga reviewed Jul 21, 2023

View reviewed changes

Arisamiga requested changes Jul 21, 2023

View reviewed changes

RomaDevWorld added 5 commits July 21, 2023 17:14

Update: messageReactionAdd.js

678b305

Update: Package list and scripts

744b5c1

Update: package.json

6c26904

Add: catch block

9f0827d

Update: nodemon config

0e0e4b5

RomaDevWorld requested a review from Arisamiga July 22, 2023 07:30

Arisamiga approved these changes Jul 22, 2023

View reviewed changes

Arisamiga merged commit 95dc1d4 into Arisamiga:main Jul 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactored and made the code look better #9

Refactored and made the code look better #9

RomaDevWorld commented Jul 20, 2023

Arisamiga left a comment

RomaDevWorld commented Jul 20, 2023

Arisamiga Jul 20, 2023

Arisamiga left a comment

RomaDevWorld commented Jul 20, 2023

RomaDevWorld commented Jul 20, 2023

Arisamiga Jul 21, 2023

RomaDevWorld Jul 21, 2023

Arisamiga Jul 21, 2023

Arisamiga Jul 21, 2023

RomaDevWorld Jul 21, 2023

RomaDevWorld Jul 21, 2023

Arisamiga Jul 21, 2023

Arisamiga left a comment •

edited

Loading

RomaDevWorld commented Jul 22, 2023 •

edited

Loading

Arisamiga left a comment

RomaDevWorld commented Jul 22, 2023

Refactored and made the code look better #9

Refactored and made the code look better #9

Conversation

RomaDevWorld commented Jul 20, 2023

Arisamiga left a comment

Choose a reason for hiding this comment

RomaDevWorld commented Jul 20, 2023

Choose a reason for hiding this comment

Arisamiga left a comment

Choose a reason for hiding this comment

RomaDevWorld commented Jul 20, 2023

RomaDevWorld commented Jul 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Arisamiga left a comment • edited Loading

Choose a reason for hiding this comment

RomaDevWorld commented Jul 22, 2023 • edited Loading

Arisamiga left a comment

Choose a reason for hiding this comment

RomaDevWorld commented Jul 22, 2023

Arisamiga left a comment •

edited

Loading

RomaDevWorld commented Jul 22, 2023 •

edited

Loading