/core-commander

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move from javascript to typescript #114

Merged
merged 14 commits into from Feb 11, 2019

Conversation

Reviewers

@supaiku0 supaiku0

@alexbarnsley alexbarnsley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@faustbrian @ArkEcosystemBot
@faustbrian
Copy link
Contributor

faustbrian commented Feb 11, 2019

Proposed changes

Merge all changes needed to work with Core 2.1 to master.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Sign in to view
Copy link
Member

ArkEcosystemBot commented Feb 11, 2019

@alexbarnsley @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot ArkEcosystemBot requested review from alexbarnsley and supaiku0 Feb 11, 2019

@faustbrian faustbrian merged commit 6a17d72 into master Feb 11, 2019

@faustbrian faustbrian deleted the develop branch Feb 11, 2019

@ArkEcosystemBot ArkEcosystemBot referenced this pull request Feb 18, 2019

Open

[Weekly Digest] Feb 11, 2019 - Feb 17, 2019 #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment