Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make next4 compliant #13

Merged
merged 3 commits into from Nov 5, 2019

Conversation

@Lemii
Copy link
Contributor

Lemii commented Nov 1, 2019

This PR changes the following:

  • Update dependencies to use the latest next4 version
  • Changes random business/bridgename name generation to comply with new validation (it previously used Math.random() which returns an illegal period character)
  • Changes default uri values to comply with new validation
@Lemii Lemii requested review from boldninja, faustbrian and supaiku0 as code owners Nov 1, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Nov 1, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@Lemii Lemii changed the title Update/next4 refactor: make next4 compliant Nov 1, 2019
package.json Outdated Show resolved Hide resolved
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Nov 5, 2019

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@supaiku0 supaiku0 merged commit 1f1824c into ArkEcosystem:master Nov 5, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Nov 5, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Nov 5, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.