refactor: rename core-interfaces to prefix an 'I'

fix: shared.Config class having buggy 'init' method

packages/core-api/src/index.ts

@@ -6,9 +6,9 @@ export const plugin : Container.PluginDescriptor = {
     pkg: require("../package.json"),
     defaults,
     alias: "api",
-    async register(container: Container.Container, options) {
+    async register(container: Container.IContainer, options) {
         if (!options.enabled) {
-            container.resolvePlugin<Logger.Logger>("logger").info("Public API is disabled :grey_exclamation:");
+            container.resolvePlugin<Logger.ILogger>("logger").info("Public API is disabled :grey_exclamation:");
 
             return false;
         }
@@ -18,9 +18,9 @@ export const plugin : Container.PluginDescriptor = {
 
         return server;
     },
-    async deregister(container: Container.Container, options) {
+    async deregister(container: Container.IContainer, options) {
         if (options.enabled) {
-            container.resolvePlugin<Logger.Logger>("logger").info(`Stopping Public API`);
+            container.resolvePlugin<Logger.ILogger>("logger").info(`Stopping Public API`);
 
             return container.resolvePlugin("api").stop();
         }

packages/core-api/src/repositories/repository.ts

@@ -7,7 +7,7 @@ import { IRepository } from "../interfaces/repository";
 export abstract class Repository implements IRepository {
     public database = app.resolvePlugin<PostgresConnection>("database");
     public cache = this.database.getCache();
-    public transactionPool = app.resolvePlugin<TransactionPool.TransactionPool>("transactionPool");
+    public transactionPool = app.resolvePlugin<TransactionPool.ITransactionPool>("transactionPool");
     public model = this.getModel();
     public query = this.model.query();
     public columns: string[] = [];

packages/core-api/src/versions/1/blocks/transformer.ts

@@ -3,7 +3,7 @@ import { Blockchain } from "@arkecosystem/core-interfaces";
 import { bignumify } from "@arkecosystem/core-utils";
 
 export function transformBlockLegacy(model) {
-    const lastBlock = app.resolvePlugin<Blockchain.Blockchain>("blockchain").getLastBlock();
+    const lastBlock = app.resolvePlugin<Blockchain.IBlockchain>("blockchain").getLastBlock();
 
     return {
         id: model.id,

packages/core-api/src/versions/1/delegates/schema.ts

@@ -1,7 +1,7 @@
 import { app } from "@arkecosystem/core-container";
 import { Blockchain } from "@arkecosystem/core-interfaces";
 
-const lastBlock = app.resolvePlugin<Blockchain.Blockchain>("blockchain").getLastBlock();
+const lastBlock = app.resolvePlugin<Blockchain.IBlockchain>("blockchain").getLastBlock();
 
 export const forgingStatus: object = {
     type: "object",

packages/core-api/src/versions/1/peers/controller.ts

@@ -5,12 +5,12 @@ import Hapi from "hapi";
 import { Controller } from "../shared/controller";
 
 export class PeersController extends Controller {
-    protected p2p: P2P.Monitor;
+    protected p2p: P2P.IMonitor;
 
     public constructor() {
         super();
 
-        this.p2p = app.resolvePlugin<P2P.Monitor>("p2p");
+        this.p2p = app.resolvePlugin<P2P.IMonitor>("p2p");
     }
 
     public async index(request: Hapi.Request, h: Hapi.ResponseToolkit) {

packages/core-api/src/versions/1/shared/controller.ts

@@ -6,9 +6,9 @@ import { paginate, respondWith, respondWithCache, toCollection, toResource } fro
 
 export class Controller {
     protected config = app.getConfig();
-    protected blockchain = app.resolvePlugin<Blockchain.Blockchain>("blockchain");
+    protected blockchain = app.resolvePlugin<Blockchain.IBlockchain>("blockchain");
     protected database = app.resolvePlugin<PostgresConnection>("database");
-    protected logger = app.resolvePlugin<Logger.Logger>("logger");
+    protected logger = app.resolvePlugin<Logger.ILogger>("logger");
 
     protected paginate(request: Hapi.Request): any {
         return paginate(request);

packages/core-api/src/versions/1/transactions/controller.ts

@@ -5,7 +5,7 @@ import Hapi from "hapi";
 import { Controller } from "../shared/controller";
 
 export class TransactionsController extends Controller {
-    protected transactionPool = app.resolvePlugin<TransactionPool.TransactionPool>("transactionPool");
+    protected transactionPool = app.resolvePlugin<TransactionPool.ITransactionPool>("transactionPool");
 
     public constructor() {
         super();

packages/core-api/src/versions/1/transactions/transformer.ts

@@ -5,7 +5,7 @@ import { crypto, models } from "@arkecosystem/crypto";
 
 export function transformTransactionLegacy(model) {
     const config = app.getConfig();
-    const blockchain = app.resolvePlugin<Blockchain.Blockchain>("blockchain");
+    const blockchain = app.resolvePlugin<Blockchain.IBlockchain>("blockchain");
 
     const data: any = new models.Transaction(model.serialized.toString("hex"));
 

packages/core-api/src/versions/2/peers/controller.ts

@@ -69,7 +69,7 @@ export class PeersController extends Controller {
 
     public async suspended(request: Hapi.Request, h: Hapi.ResponseToolkit) {
         try {
-            const peers = app.resolvePlugin<P2P.Monitor>("p2p").getSuspendedPeers();
+            const peers = app.resolvePlugin<P2P.IMonitor>("p2p").getSuspendedPeers();
 
             return super.respondWithCollection(
                 request,

packages/core-api/src/versions/2/shared/controller.ts

@@ -15,7 +15,7 @@ import {
 
 export class Controller {
     protected config = app.getConfig();
-    protected blockchain = app.resolvePlugin<Blockchain.Blockchain>("blockchain");
+    protected blockchain = app.resolvePlugin<Blockchain.IBlockchain>("blockchain");
     protected database = app.resolvePlugin<PostgresConnection>("database");
 
     protected paginate(request: Hapi.Request): any {

packages/core-api/src/versions/2/transactions/controller.ts

@@ -4,11 +4,11 @@ import Boom from "boom";
 import Hapi from "hapi";
 import { Controller } from "../shared/controller";
 
-import { TransactionGuardImpl, TransactionPoolImpl } from "@arkecosystem/core-transaction-pool";
+import { TransactionGuard, TransactionPool } from "@arkecosystem/core-transaction-pool";
 import { constants } from "@arkecosystem/crypto";
 
 export class TransactionsController extends Controller {
-    private transactionPool = app.resolvePlugin<TransactionPoolImpl>("transactionPool");
+    private transactionPool = app.resolvePlugin<TransactionPool>("transactionPool");
 
     public constructor() {
         super();
@@ -30,12 +30,12 @@ export class TransactionsController extends Controller {
                 return Boom.serverUnavailable("Transaction pool is disabled.");
             }
 
-            const guard = new TransactionGuardImpl(this.transactionPool);
+            const guard = new TransactionGuard(this.transactionPool);
 
             const result = await guard.validate(request.payload.transactions);
 
             if (result.broadcast.length > 0) {
-                app.resolvePlugin<P2P.Monitor>("p2p").broadcastTransactions(guard.getBroadcastTransactions());
+                app.resolvePlugin<P2P.IMonitor>("p2p").broadcastTransactions(guard.getBroadcastTransactions());
             }
 
             return {

packages/core-api/src/versions/2/transactions/transformer.ts

@@ -5,7 +5,7 @@ import { crypto, models } from "@arkecosystem/crypto";
 
 export function transformTransaction(model) {
     const config = app.getConfig();
-    const blockchain = app.resolvePlugin<Blockchain.Blockchain>("blockchain");
+    const blockchain = app.resolvePlugin<Blockchain.IBlockchain>("blockchain");
 
     const data: any = new models.Transaction(model.serialized.toString("hex"));
     const lastBlock = blockchain.getLastBlock();

packages/core-blockchain/__tests__/blockchain.test.ts

@@ -8,8 +8,8 @@ import { asValue } from "awilix";
 import axios from "axios";
 import MockAdapter from "axios-mock-adapter";
 import delay from "delay";
-import { BlockchainImpl } from "../src/blockchain";
-import { defaults } from "../src/defaults";
+import { Blockchain } from "../dist/blockchain";
+import { defaults } from "../dist/defaults";
 import { setUp, tearDown } from "./__support__/setup";
 
 const axiosMock = new MockAdapter(axios);
@@ -18,7 +18,7 @@ const { Block, Wallet } = models;
 let genesisBlock;
 let configManager;
 let container;
-let blockchain: BlockchainImpl;
+let blockchain: Blockchain;
 let logger;
 let loggerDebugBackup;
 let peerMock;

packages/core-blockchain/__tests__/state-machine.test.ts

@@ -1,11 +1,11 @@
 import "@arkecosystem/core-test-utils";
 import { asValue } from "awilix";
-import { BlockchainImpl } from "../src/blockchain";
+import { Blockchain } from "../src/blockchain";
 import { setUp, tearDown } from "./__support__/setup";
 
 let stateMachine;
 let container;
-let blockchain: BlockchainImpl;
+let blockchain: Blockchain;
 
 beforeAll(async () => {
     container = await setUp();

packages/core-blockchain/src/blockchain.ts

@@ -1,20 +1,20 @@
 /* tslint:disable:max-line-length */
 import { app } from "@arkecosystem/core-container";
 import { PostgresConnection } from "@arkecosystem/core-database-postgres";
-import { Blockchain, EventEmitter, Logger, P2P, TransactionPool } from "@arkecosystem/core-interfaces";
+import { Blockchain as blockchain, EventEmitter, Logger, P2P, TransactionPool } from "@arkecosystem/core-interfaces";
 import { models, slots } from "@arkecosystem/crypto";
 
 import delay from "delay";
 import pluralize from "pluralize";
 import { ProcessQueue, Queue, RebuildQueue } from "./queue";
 import { stateMachine } from "./state-machine";
 
-const logger = app.resolvePlugin<Logger.Logger>("logger");
+const logger = app.resolvePlugin<Logger.ILogger>("logger");
 const config = app.getConfig();
 const emitter = app.resolvePlugin<EventEmitter.EventEmitter>("event-emitter");
 const { Block } = models;
 
-export class BlockchainImpl implements Blockchain.Blockchain {
+export class Blockchain implements blockchain.IBlockchain {
     public isStopped: boolean;
     public options: any;
     public processQueue: ProcessQueue;
@@ -664,7 +664,7 @@ export class BlockchainImpl implements Blockchain.Blockchain {
 
     /**
      * Get the state of the blockchain.
-     * @return {StateStorage}
+     * @return {IStateStorage}
      */
     get state() {
         return stateMachine.state;
@@ -675,15 +675,15 @@ export class BlockchainImpl implements Blockchain.Blockchain {
      * @return {P2PInterface}
      */
     get p2p() {
-        return app.resolvePlugin<P2P.Monitor>("p2p");
+        return app.resolvePlugin<P2P.IMonitor>("p2p");
     }
 
     /**
      * Get the transaction handler.
      * @return {TransactionPool}
      */
     get transactionPool() {
-        return app.resolvePlugin<TransactionPool.TransactionPool>("transactionPool");
+        return app.resolvePlugin<TransactionPool.ITransactionPool>("transactionPool");
     }
 
     /**

packages/core-blockchain/src/index.ts

@@ -1,6 +1,6 @@
-import { Blockchain, Container } from "@arkecosystem/core-interfaces";
+import { Container } from "@arkecosystem/core-interfaces";
 import { asValue } from "awilix";
-import { BlockchainImpl } from "./blockchain";
+import { Blockchain } from "./blockchain";
 import { config } from "./config";
 import { defaults } from "./defaults";
 import { stateStorage } from "./state-storage";
@@ -13,8 +13,8 @@ export const plugin : Container.PluginDescriptor = {
     pkg: require("../package.json"),
     defaults,
     alias: "blockchain",
-    async register(container: Container.Container, options) {
-        const blockchain = new BlockchainImpl(options);
+    async register(container: Container.IContainer, options) {
+        const blockchain = new Blockchain(options);
 
         config.init(options);
 
@@ -26,13 +26,13 @@ export const plugin : Container.PluginDescriptor = {
 
         return blockchain;
     },
-    async deregister(container: Container.Container, options) {
-        await container.resolvePlugin<Blockchain.Blockchain>("blockchain").stop();
+    async deregister(container: Container.IContainer, options) {
+        await container.resolvePlugin<Blockchain>("blockchain").stop();
     },
 };
 
 /**
  * Access to the state.
- * @type {StateStorage}
+ * @type {IStateStorage}
  */
 export { stateStorage };

packages/core-blockchain/src/queue/index.ts

@@ -10,7 +10,7 @@ export class Queue {
 
     /**
      * Create an instance of the queue.
-     * @param  {BlockchainImpl} blockchain
+     * @param  {Blockchain} blockchain
      * @param  {Object} events
      * @return {void}
      */

packages/core-blockchain/src/queue/interface.ts

@@ -5,7 +5,7 @@ export abstract class QueueInterface {
 
     /**
      * Create an instance of the process queue.
-     * @param  {BlockchainImpl} blockchain
+     * @param  {Blockchain} blockchain
      * @param  {String} event
      * @return {void}
      */

packages/core-blockchain/src/queue/process.ts

@@ -4,13 +4,13 @@ import { models } from "@arkecosystem/crypto";
 import async from "async";
 import { QueueInterface } from "./interface";
 
-const logger = app.resolvePlugin<Logger.Logger>("logger");
+const logger = app.resolvePlugin<Logger.ILogger>("logger");
 const { Block } = models;
 
 export class ProcessQueue extends QueueInterface {
     /**
      * Create an instance of the process queue.
-     * @param  {BlockchainImpl} blockchain
+     * @param  {Blockchain} blockchain
      * @return {void}
      */
     constructor(blockchain, event) {

packages/core-blockchain/src/queue/rebuild.ts

@@ -4,13 +4,13 @@ import { models } from "@arkecosystem/crypto";
 import async from "async";
 import { QueueInterface } from "./interface";
 
-const logger = app.resolvePlugin<Logger.Logger>("logger");
+const logger = app.resolvePlugin<Logger.ILogger>("logger");
 const { Block } = models;
 
 export class RebuildQueue extends QueueInterface {
     /**
      * Create an instance of the process queue.
-     * @param  {BlockchainImpl} blockchain
+     * @param  {Blockchain} blockchain
      * @return {void}
      */
     constructor(blockchain, event) {

packages/core-blockchain/src/state-machine.ts

@@ -12,24 +12,24 @@ import { blockchainMachine } from "./machines/blockchain";
 import { stateStorage } from "./state-storage";
 import { tickSyncTracker } from "./utils/tick-sync-tracker";
 
-import { BlockchainImpl } from "./blockchain";
+import { Blockchain } from "./blockchain";
 
 const { Block } = models;
 const config = app.getConfig();
 const emitter = app.resolvePlugin<EventEmitter.EventEmitter>("event-emitter");
-const logger = app.resolvePlugin<Logger.Logger>("logger");
+const logger = app.resolvePlugin<Logger.ILogger>("logger");
 
 /**
- * @type {StateStorage}
+ * @type {IStateStorage}
  */
 blockchainMachine.state = stateStorage;
 
 /**
  * The blockchain actions.
- * @param  {BlockchainImpl} blockchain
+ * @param  {Blockchain} blockchain
  * @return {Object}
  */
-blockchainMachine.actionMap = (blockchain: BlockchainImpl) => ({
+blockchainMachine.actionMap = (blockchain: Blockchain) => ({
     blockchainReady: () => {
         if (!stateStorage.started) {
             stateStorage.started = true;

packages/core-blockchain/src/state-storage.ts

@@ -9,7 +9,7 @@ import { config } from "./config";
 import { blockchainMachine } from "./machines/blockchain";
 
 const { Block } = models;
-const logger = app.resolvePlugin<Logger.Logger>("logger");
+const logger = app.resolvePlugin<Logger.ILogger>("logger");
 
 // Stores the last n blocks in ascending height. The amount of last blocks
 // can be configured with the option `state.maxLastBlocks`.

packages/core-blockchain/src/utils/tick-sync-tracker.ts

@@ -2,14 +2,14 @@ import { app } from "@arkecosystem/core-container";
 import { Logger, P2P } from "@arkecosystem/core-interfaces";
 import prettyMs from "pretty-ms";
 
-const logger = app.resolvePlugin<Logger.Logger>("logger");
+const logger = app.resolvePlugin<Logger.ILogger>("logger");
 let tracker = null;
 
 export function tickSyncTracker(blockCount, count) {
     if (!tracker) {
         tracker = {
             start: new Date().getTime(),
-            networkHeight: app.resolvePlugin<P2P.Monitor>("p2p").getNetworkHeight(),
+            networkHeight: app.resolvePlugin<P2P.IMonitor>("p2p").getNetworkHeight(),
             blocksInitial: +count,
             blocksDownloaded: +count,
             blocksSession: 0,

packages/core-container/__tests__/registrars/plugin.test.ts

@@ -1,7 +1,7 @@
 import "jest-extended";
 
 import { resolve } from "path";
-import { ContainerImpl } from "../../src/container";
+import { Container } from "../../src/container";
 import { PluginRegistrar } from "../../src/registrars/plugin";
 
 const stubPluginPath = resolve(__dirname, "../__stubs__");
@@ -10,7 +10,7 @@ let instance;
 beforeEach(() => {
     process.env.ARK_PATH_CONFIG = stubPluginPath;
 
-    instance = new PluginRegistrar(new ContainerImpl());
+    instance = new PluginRegistrar(new Container());
 });
 
 describe("Plugin Registrar", () => {