Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace axios with got #2193

Closed
faustbrian opened this Issue Mar 3, 2019 · 0 comments

Comments

Projects
1 participant
@faustbrian
Copy link
Collaborator

faustbrian commented Mar 3, 2019

https://github.com/sindresorhus/got is a lot more lightweight and axios has known issues with timeouts that can randomly cause issues.

This also means we will replace axios-mock with https://github.com/nock/nock which can mock everything that uses the http.request method, not just axios calls.

@faustbrian faustbrian added this to the 2.3.0 milestone Mar 3, 2019

@faustbrian faustbrian added this to To do in 2.3.0 via automation Mar 3, 2019

@faustbrian faustbrian self-assigned this Mar 3, 2019

@faustbrian faustbrian referenced this issue Mar 6, 2019

Merged

refactor: replace axios with got #2203

3 of 3 tasks complete

@kristjank kristjank moved this from To do to In progress in 2.3.0 Mar 12, 2019

@faustbrian faustbrian closed this Mar 12, 2019

2.3.0 automation moved this from In progress to Closed Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.